Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11289 closed defect (fixed)

Second Hand does not apply to Car Rental, but it does apply to Car Dealers

Reported by: dobratzp Owned by: team
Priority: normal Milestone: 15.04
Component: Internal preset Version:
Keywords: template_report Cc:

Description

When using the Presets to add a Car Rental shop the option of yes/no/only for the second_hand key is shown. By definition, all car rentals are second hand. It would make much more sense not to have the second_hand key on car rental shops, but it would make sense to have it on Car Dealers.

These dialogs are found through the following menu items:

Presets => Transport => Car => Car Dealer
Presets => Transport => Car => Rental

I am attaching a patch to update data/defaultpresets.xml

Revision: 8159
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: stoecker
Last Changed Date: 2015-03-29 14:37:50 +0200 (Sun, 29 Mar 2015)
Build-Date: 2015-03-30 01:30:55
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8159

Identification: JOSM/1.5 (8159 en) Mac OS X 10.10.2
Memory Usage: 362 MB / 1820 MB (320 MB allocated, but free)
Java version: 1.8.0_25, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM

Plugins:
- FixAddresses (30892)
- OpeningHoursEditor (30962)
- reverter (30990)
- utilsplugin2 (31072)

Attachments (1)

car_dealer_rental_patch.txt (1.1 KB) - added by dobratzp 5 years ago.
update patch to really put the second_hand tag in car dealer (not car repair)

Download all attachments as: .zip

Change History (5)

comment:1 Changed 5 years ago by Klumbumbus

Component: CoreInternal preset
Milestone: 15.04

comment:2 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8164/josm:

fix #11289 - remove second_hand from car rental and add second_hand to car dealer (modified patch by dobratzp)

comment:3 Changed 5 years ago by Klumbumbus

In your patch you added it to car repair ;)

Changed 5 years ago by dobratzp

Attachment: car_dealer_rental_patch.txt added

update patch to really put the second_hand tag in car dealer (not car repair)

comment:4 Changed 5 years ago by dobratzp

Oops, yes and for similar reasons second_hand does also not make sense to have on car_repair as all cars leaving car repair shops are in fact used.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.