Modify

Opened 6 years ago

Last modified 2 years ago

#11288 reopened defect

Can't cancel undelete process

Reported by: naoliv Owned by: team
Priority: normal Milestone:
Component: Plugin undelete Version:
Keywords: Cc:

Description

Run FileUndelete object and insert all this:

n2596072120 n2596072107 n2596072155 n2596072201 n2596072206 n2596072130 n2596072125 n3144115720 n3144115721 n3144115722 n3144115723 n3144115724 n3144115725 n3144115726 n3144115727 n3144115728 n3144115929 n2596071253 n2596071234 n2596071209 n2596071181 n2596071144 n2596071117 n2596071110 n2596071109 n2596071116 n2596071147 n2596071177 n1327926868 n1327927237 n1327927489 n1327926748 n1327927184 n1327927116 n1327927379 n1327926633 n1327927231 n1327927584 n1327926746 n1327927087 n1327927329 n1327926613 n1327926836 n1327926569 n1327926788 n1327927134 n1327927387 n1327926646 n1327926884 n1327927246 n1327927501 n1327927418 n1327926595 n1327926909 n1327927156 n1327927527 n1327926682 n1327927031 n1327927275 n1327926965 n1327927207 n1327927563 n1327926728 n1327927077 n1327927319 n1327926600 n1327926824 n1327926766 n1327926996 n1327927352 n1327926535 n1327926850 n1327927103 n1327927468 n1327926993 n1327926690 n1327926912 n1327927278 n1327927090 n1327927458 n1327926614 n1327926951 n1327926668 n1327927017 n1327927267 n1327926554 n1327926777 n1327926705 n1327926935 n1327927294 n1327926580 n1327927343 n1327926524 n1327926840 n1327927541 n1327926802 n1327927051 n1327927412 n1327926624 n1327926904 n1327927151 n1327927515 n1383421618 n1383421723 n1383421840 n1383421894 n1383421953 n1383422001 n1383422058 n1383422110 n1383422151 n1383422182 n1383422221 n1383422239 n1383422284 n1383422303 n1383422305 n1383422306 n1383422304 n1383422314 n1383422322 n1383422320 n1383422312 n1383422316 n1383422328 n1383422330 n1383422294 n1383422280 n1383422247 n1383422211 n1383422173 n1383422162 n1383422135 n1383422139 n1383422070 n1383422069 n1383422049 n3036259456 n3036259457 n3036259459 n1383421970 n3036259458 n1383421908 n3036315215 n3036315216 n1383421883 n1383421867 n1383421858 n1383421842 n1383421828 n1383421810 n1383421807 n1383421651 n1383421632 n1383421625 n2596070880 n2596070879 n2596070876 n2596070857 n2596070853 n2596070844 n2596070841 n2596070847 n2596070858 n2596070868 n2596070877 n2596070676 n2596070665 n2596070671 n2596070663 n2596070640 n2596070648 n2596070631 n2596070578 n2596070574 n2596070531 n2596070532 n2596070509 n2596070511 n2596070595 n2596070605 n2985394862 n2985394863 n2985394864 n2985394865 n2985394866 n2985394867 n1383421885 n632025791 n632025792 n632025793 n632025794 n632025760 n632025761 n632025762 n632025763 n632025764 n1383421577 n632025765 n2702374821 n2702374819 n632025766 n632025767 n632025768 n632025769 n632025770 n632025771 n632025773 n632025774 n632025775 n1383421812 n632025799 n632025798 n632025797 n632025796 n632025795 n1383421669 n1383421665 n1383421675 n1383421769 n1383421847 n1383421996 n1383422053 n1383422087 n1383422155 n1383422201 n1383422245 n1383422281 n1383422299 n1383421780 n1383421767 n1383421736 n1383421691 n1383421671 n1383421654 n1383421599 n1383421595 n1383421572 n1383421512 n1383421435 n1383421409 n1383421379 n1383421340 n632025789 n1383421826 n1383421892 n1383421825 n1383421764 n1383421713 n1383421639 n1383421583 n1383421504 n1383421492 n1383421527 n1383421548 n1383421558 n1383421615 n1383421890 n1383421881 n1383421879 n1383421874 n1383421861 n1383421856 n1383421855 n1383421425 n1383421427 n1383421458 n1383421472 n1383421488 n1383421482 n1383421473 n1383421485 n1383421465 n1383421456 n1383421448 n1383421433 n1383421423 n1383421421 n2702395594 n1383421354 n1383421346 n1383421343 n1383421338 n1383421307 n1383421286 n1383421269 n1383421267 n1383421271 n1383421283 n1383421359 n3416858670 n3416860890 n2726220710 n3036305907 n3036305944 w253719075 w309099036 w253716641 w117976433 w117976452 w117976470 w117976468 w117976474 w117976466 w117976444 w117976503 w117976562 w117976489 w124253243 w253719231 w253716916 w294898907 w124253294 w49734452 w49734453 w124253207 w124253215 w124253292 w124253256 w124253228 w124253291 r1627937

Now try to cancel. Everytime you hit Cancel it starts to download a new object (while it should cancel all the process)

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-03-30 01:30:55
Last Changed Author: stoecker
Revision: 8159
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-03-29 14:37:50 +0200 (Sun, 29 Mar 2015)
Last Changed Rev: 8159

Identification: JOSM/1.5 (8159 pt_BR) Linux Debian GNU/Linux 8.0 (jessie)
Memory Usage: 781 MB / 4029 MB (177 MB allocated, but free)
Java version: 1.7.0_75, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u75-2.5.4-3
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
- AddrInterpolation (30892)
- Create_grid_of_ways (30892)
- FastDraw (30892)
- FixAddresses (30892)
- ImageryCache (30892)
- OpeningHoursEditor (30962)
- PicLayer (30962)
- SimplifyArea (30962)
- buildings_tools (30955)
- download_along (30892)
- editgpx (30892)
- geotools (31068)
- graphview (30892)
- jts (31002)
- measurement (30892)
- merge-overlap (30988)
- opendata (31050)
- pdfimport (30892)
- poly (31056)
- reverter (30990)
- tagging-preset-tester (30892)
- todo (29154)
- turnrestrictions (31034)
- undelete (30892)
- utilsplugin2 (31040)

Attachments (0)

Change History (6)

comment:1 Changed 2 years ago by GerdP

Resolution: irreproducible
Status: newclosed

I cannot reproduce this problem with the current binaries. Please reopen if you can.

comment:2 Changed 2 years ago by naoliv

Resolution: irreproducible
Status: closedreopened

Still reproducible :-)
If you take a look at https://youtu.be/TnBZu_Rd0sA, until 3:59 (when it's only downloading the object/changeset history), we can cancel.

After 3:59 when it starts to download the objects we can't cancel anymore (see that clicking on Cancel does nothing and I have to Ctrl+C JOSM on the console)

comment:3 Changed 2 years ago by GerdP

OK, now I understand.

comment:4 Changed 2 years ago by GerdP

It's quite easy to change the behaviour so that cancel always stops the operation but I wonder what should happen when you cancel the operation after some objects were restored. If a new layer was used I'd say that the layer should be empty, but what should happen when objects were added to an existing layer?

comment:5 Changed 2 years ago by naoliv

Is it possible to "wrap" the process inside an undo operation and undo it if it's canceled?

comment:6 Changed 2 years ago by GerdP

Everything is possible, it's just a matter of time and work ;)
Up to now the plugin doesn't use the undo/redo handler, it just adds data to the layer.
And it starts new tasks while doing so. I've still not learned how to handle that so that I finally know that all tasks are done/canceled. I'm a newbe to this kind of threading...
Anyway, in the last days I've improved the plugin so that it works much faster now with JOSM r14763 or later, so maybe cancel is less important now ;)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as reopened The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to naoliv
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.