Modify

Opened 4 years ago

Closed 4 years ago

#11223 closed enhancement (fixed)

remove waterway=wadi from preset and complain in validator about objects with such tag

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 15.03
Component: Core validator Version:
Keywords: template_report Cc:

Description

As discussed on tagging mailing list[a] and described on wiki[b] this tag is ambiguous. It may mean ephemeral river, valley, typical course of flash floods. What worse word wadi is used in multiple languages with multiple meanings. waterway=wadi is also not allowing to differentiate between large and small waterways.

It is recommended to use waterway=river/waterway=stream + intermittent=yes for waterways, natural=valley for valleys.

I am proposing to drop rendering of this tag.

[a] https://lists.openstreetmap.org/pipermail/tagging/2015-January/thread.html - thread "waterway=wadi problem"
[b] http://wiki.openstreetmap.org/wiki/Tag:waterway%3Dwadi

What steps will reproduce the problem?

  1. create way
  2. tag it as waterway=wadi
  3. run validator

What is the expected result?

Value wadi is not proposed during editing.
Validator complains about waterway=wadi.

What happens instead?

Value should not be in presets.
Validator should complain - something like "use waterway=river/waterway=stream + intermittent=yes for waterways, natural=valley for valleys"

Please provide any additional information below. Attach a screenshot if possible.

I am asking to revert #9013 and add validator warning. Automatic fix is not feasible.

Revision: 8132
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: Don-vip
Last Changed Date: 2015-03-10 01:17:39 +0100 (Tue, 10 Mar 2015)
Build-Date: 2015-03-10 02:31:04
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8132

Identification: JOSM/1.5 (8132 en) Linux Ubuntu 14.04.2 LTS
Memory Usage: 381 MB / 889 MB (124 MB allocated, but free)
Java version: 1.8.0_40, Oracle Corporation, Java HotSpot(TM) Server VM
Dataset consistency test: No problems found

Plugins:
- FastDraw (30892)
- OpeningHoursEditor (30962)
- PicLayer (30962)
- buildings_tools (30955)
- continuosDownload (1413902943)
- geotools (31000)
- jts (31002)
- log4j (30892)
- measurement (30892)
- undelete (30892)
- wikipedia (31035)

Attachments (0)

Change History (2)

comment:1 Changed 4 years ago by Klumbumbus

Milestone: 15.03

There is a similar problem with tag:waterway=rapids, but it seems there is no real established alternitive tagging scheme.

comment:2 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8135/josm:

fix #11223 - remove waterway=wadi and waterway=rapids, update natural=ridge, natural=valley and intermittent=yes

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.