Opened 10 years ago
Last modified 4 years ago
#11176 reopened enhancement
Propose to upload notes in upload dialog
Reported by: | malenki | Owned by: | ToeBee |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core notes | Version: | latest |
Keywords: | upload | Cc: | Kmpopppe |
Description
When a note was created with the plugin it was sufficient to click "OK" after writing it to get it published.
Now one needs to click "save" additional to [OK] which I find is counter intuitive to both the handling prior in the Plugin and on the OSM website.
Since I wasn't aware of this behaviour several notes I created but didn't "save" are lost.
IMHO the save-button is superfluous and the behaviour should be as on the website and in the plugin: Make clicking [OK] publish the note.
Attachments (0)
Change History (21)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
Version: | → latest |
---|
The note layer does complain, see #11177.
But since I usually have some layers with undeleted data which shouldn't be uploaded I don't pay much attention to this.
comment:3 by , 10 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Agreed with ToeBee: notes handling must be consistent with all other data.
comment:4 by , 10 years ago
In addition, you now can add new lines and new paragraphs to a not which was not possible in the past.
follow-up: 6 comment:5 by , 10 years ago
Resolution: | wontfix |
---|---|
Status: | closed → reopened |
ToeBee just made the suggestion that there should be a checkbox in the upload dialog
[x] Upload changes of OSM notes
which I find a very good idea and which should be checked by default imho.
comment:6 by , 10 years ago
Replying to malenki:
ToeBee just made the suggestion that there should be a checkbox in the upload dialog
[x] Upload changes of OSM notes
which I find a very good idea and which should be checked by default imho.
good idea
comment:7 by , 10 years ago
Summary: | note handling changed from plugin to built-in → note upload handling changed from plugin to built-in |
---|
comment:8 by , 10 years ago
Type: | defect → enhancement |
---|
follow-ups: 10 11 comment:9 by , 10 years ago
I just lost comments for three notes because JOSM didn't warn me about unsaved changes to notes on exit. At the moment this is really a bad user experience. I wonder how many other people already lost comments to existing nodes or even created new ones with JOSM silently throwing them away at exit.
comment:10 by , 10 years ago
Replying to anonymous:
I just lost comments for three notes because JOSM didn't warn me about unsaved changes to notes on exit. At the moment this is really a bad user experience. I wonder how many other people already lost comments to existing nodes or even created new ones with JOSM silently throwing them away at exit.
That was my comment, forgot to log in.
comment:11 by , 10 years ago
follow-up: 13 comment:12 by , 10 years ago
Oh, maybe JOSM did warn me but I ignored the popup because I already did upload all my data. I think it might be a good idea to also upload notes when uploading data.
comment:13 by , 10 years ago
comment:14 by , 7 years ago
Keywords: | upload added |
---|---|
Summary: | note upload handling changed from plugin to built-in → Propose to upload notes in upload dialog |
comment:15 by , 7 years ago
Milestone: | → 17.08 |
---|
comment:16 by , 7 years ago
Milestone: | 17.08 → 17.09 |
---|
comment:17 by , 7 years ago
Milestone: | 17.09 |
---|
Not so easy to make it fit in the upload dialog correctly
comment:18 by , 7 years ago
@don-vip what if we make the "Upload notes on uploading OSM data" an option in JOSM configuration and create a list of post-upload tasks in UploadAction class. UploadNotesAction class can create a runnable and add to this list. I can create a patch for this if you think the design is fine.
comment:19 by , 4 years ago
There is now a new plugin which handles note closing during upload: https://github.com/kmpoppe/noteSolver/
comment:20 by , 4 years ago
Cc: | added |
---|
comment:21 by , 4 years ago
Ah, thanks for mentioning me, @Klumbumbus @simon04. Issues can be reported directly in GitHub :-)
This behavior is how JOSM works with all other data. When you create a new node, it isn't published until you upload it.
The note layer should complain if you try to delete it or exit JOSM without uploading new notes. Is it not doing this?