Modify

Opened 3 years ago

Last modified 7 weeks ago

#11176 reopened enhancement

Propose to upload notes in upload dialog

Reported by: malenki Owned by: ToeBee
Priority: normal Milestone:
Component: Core notes Version: latest
Keywords: upload Cc:

Description

When a note was created with the plugin it was sufficient to click "OK" after writing it to get it published.
Now one needs to click "save" additional to [OK] which I find is counter intuitive to both the handling prior in the Plugin and on the OSM website.
Since I wasn't aware of this behaviour several notes I created but didn't "save" are lost.

IMHO the save-button is superfluous and the behaviour should be as on the website and in the plugin: Make clicking [OK] publish the note.

Attachments (0)

Change History (18)

comment:1 Changed 3 years ago by ToeBee

This behavior is how JOSM works with all other data. When you create a new node, it isn't published until you upload it.

The note layer should complain if you try to delete it or exit JOSM without uploading new notes. Is it not doing this?

comment:2 Changed 3 years ago by malenki

Version: latest

The note layer does complain, see #11177.
But since I usually have some layers with undeleted data which shouldn't be uploaded I don't pay much attention to this.

comment:3 Changed 3 years ago by Don-vip

Resolution: wontfix
Status: newclosed

Agreed with ToeBee: notes handling must be consistent with all other data.

comment:4 Changed 3 years ago by skyper

In addition, you now can add new lines and new paragraphs to a note which was not possible in the past.

Last edited 3 years ago by skyper (previous) (diff)

comment:5 Changed 3 years ago by malenki

Resolution: wontfix
Status: closedreopened

ToeBee just made the suggestion that there should be a checkbox in the upload dialog
[x] Upload changes of OSM notes
which I find a very good idea and which should be checked by default imho.

comment:6 in reply to:  5 Changed 3 years ago by Klumbumbus

Replying to malenki:

ToeBee just made the suggestion that there should be a checkbox in the upload dialog
[x] Upload changes of OSM notes
which I find a very good idea and which should be checked by default imho.

good idea

comment:7 Changed 3 years ago by Klumbumbus

Summary: note handling changed from plugin to built-innote upload handling changed from plugin to built-in

comment:8 Changed 3 years ago by Don-vip

Type: defectenhancement

comment:9 Changed 3 years ago by anonymous

I just lost comments for three notes because JOSM didn't warn me about unsaved changes to notes on exit. At the moment this is really a bad user experience. I wonder how many other people already lost comments to existing nodes or even created new ones with JOSM silently throwing them away at exit.

comment:10 in reply to:  9 Changed 3 years ago by scai

Replying to anonymous:

I just lost comments for three notes because JOSM didn't warn me about unsaved changes to notes on exit. At the moment this is really a bad user experience. I wonder how many other people already lost comments to existing nodes or even created new ones with JOSM silently throwing them away at exit.

That was my comment, forgot to log in.

comment:11 in reply to:  9 Changed 3 years ago by Klumbumbus

Replying to anonymous:

JOSM silently throwing them away at exit.

JOSM displays a warning at exit like if you have an unsaved data layer. (however the upload there does not yet work, see #11177)

comment:12 Changed 3 years ago by scai

Oh, maybe JOSM did warn me but I ignored the popup because I already did upload all my data. I think it might be a good idea to also upload notes when uploading data.

comment:13 in reply to:  12 Changed 3 years ago by Klumbumbus

Replying to scai:

I think it might be a good idea to also upload notes when uploading data.

See comment:5

comment:14 Changed 5 months ago by Don-vip

Keywords: upload added
Summary: note upload handling changed from plugin to built-inPropose to upload notes in upload dialog

comment:15 Changed 5 months ago by Don-vip

Milestone: 17.08

comment:16 Changed 4 months ago by Don-vip

Milestone: 17.0817.09

comment:17 Changed 3 months ago by Don-vip

Milestone: 17.09

Not so easy to make it fit in the upload dialog correctly

comment:18 Changed 7 weeks ago by udit

@don-vip what if we make the "Upload notes on uploading OSM data" an option in JOSM configuration and create a list of post-upload tasks in UploadAction class. UploadNotesAction class can create a runnable and add to this list. I can create a patch for this if you think the design is fine.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as reopened The owner will remain ToeBee.
as The resolution will be set.
to The owner will be changed from ToeBee to the specified user.
The owner will change to malenki
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.