Propose to upload notes in upload dialog

[malenki]

When a note was created with the plugin it was sufficient to click "OK" after writing it to get it published.
Now one needs to click "save" additional to [OK] which I find is counter intuitive to both the handling prior in the Plugin and on the OSM website.
Since I wasn't aware of this behaviour several notes I created but didn't "save" are lost.

IMHO the save-button is superfluous and the behaviour should be as on the website and in the plugin: Make clicking [OK] publish the note.

[ToeBee]

This behavior is how JOSM works with all other data. When you create a new node, it isn't published until you upload it.

The note layer should complain if you try to delete it or exit JOSM without uploading new notes. Is it not doing this?

[malenki]

The note layer does complain, see #11177.
But since I usually have some layers with undeleted data which shouldn't be uploaded I don't pay much attention to this.

[Don-vip]

Agreed with ToeBee: notes handling must be consistent with all other data.

[skyper]

In addition, you now can add new lines and new paragraphs to a note which was not possible in the past.

[malenki]

ToeBee just made the suggestion that there should be a checkbox in the upload dialog
[x] Upload changes of OSM notes
which I find a very good idea and which should be checked by default imho.

[Klumbumbus]

Replying to malenki:

ToeBee just made the suggestion that there should be a checkbox in the upload dialog
[x] Upload changes of OSM notes
which I find a very good idea and which should be checked by default imho.

good idea

[anonymous]

I just lost comments for three notes because JOSM didn't warn me about unsaved changes to notes on exit. At the moment this is really a bad user experience. I wonder how many other people already lost comments to existing nodes or even created new ones with JOSM silently throwing them away at exit.

[scai]

Replying to anonymous:

I just lost comments for three notes because JOSM didn't warn me about unsaved changes to notes on exit. At the moment this is really a bad user experience. I wonder how many other people already lost comments to existing nodes or even created new ones with JOSM silently throwing them away at exit.

That was my comment, forgot to log in.

[Klumbumbus]

Replying to anonymous:

JOSM silently throwing them away at exit.

JOSM displays a warning at exit like if you have an unsaved data layer. (however the upload there does not yet work, see #11177)

[scai]

Oh, maybe JOSM did warn me but I ignored the popup because I already did upload all my data. I think it might be a good idea to also upload notes when uploading data.

[Klumbumbus]

Replying to scai:

I think it might be a good idea to also upload notes when uploading data.

See comment:5

[Don-vip]

Not so easy to make it fit in the upload dialog correctly

[udit]

@don-vip what if we make the "Upload notes on uploading OSM data" an option in JOSM configuration and create a list of post-upload tasks in UploadAction class. UploadNotesAction class can create a runnable and add to this list. I can create a patch for this if you think the design is fine.

[Klumbumbus]

There is now a new plugin which handles note closing during upload: ​https://github.com/kmpoppe/noteSolver/

[Kmpopppe]

Ah, thanks for mentioning me, @Klumbumbus @simon04. Issues can be reported directly in GitHub :-)