#11127 closed enhancement (fixed)
Test connected bridge and waterway
Reported by: | naoliv | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 15.02 |
Component: | Core validator | Version: | |
Keywords: | Cc: |
Description
Interesting to have it in JOSM?
way[bridge] > node { set node_in_bridge; } way[waterway] > node.node_in_bridge { throwWarning: tr("node must not connect waterway and bridge"); }
Attachments (0)
Change History (9)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
What if first line is changed? Stopping the suggestion just because you don't like the syntax in the test is a little counter productive, lets try to improve this
way[railway][bridge] > node, way[highway][bridge] > node { set node_in_bridge; }
comment:3 by , 10 years ago
Milestone: | → 15.02 |
---|
I didn't stop the suggestion. However we should try to avoid to include validator checks which produce false positives because this makes the people ignoring the whole validator.
comment:4 by , 10 years ago
It seems these false positive cases should be tagged with bridge=aqueduct.
So my suggestion would be to add an exception for this in the code, and also mention bridge=aqueduct in the warning message.
follow-up: 7 comment:6 by , 10 years ago
So this only warns if the bridge over a waterway shares a common node with the waterway?
comment:7 by , 10 years ago
Replying to aceman:
So this only warns if the bridge over a waterway shares a common node with the waterway?
Yes, which should be the most common error case.
follow-up: 9 comment:8 by , 10 years ago
Yes, that is fine.
I have a similar ticket #9304 for incorrectly connected highways. Maybe that can be implemented too now?
comment:9 by , 10 years ago
Replying to aceman:
I have a similar ticket #9304 for incorrectly connected highways. Maybe that can be implemented too now?
I don't think this is possible with the current mapcss validator syntax. It would require atleast #10299. Or this is implemented via java code. (I'm not able to write Java code.)
This would produce false positives for waterways, which are bridges
https://de.wikipedia.org/wiki/Datei:Flexdorfer-Trogbr%C3%BCcke.JPG
https://de.wikipedia.org/wiki/Datei:KanalbrueckeDigoin.jpg