Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11127 closed enhancement (fixed)

Test connected bridge and waterway

Reported by: naoliv Owned by: team
Priority: normal Milestone: 15.02
Component: Core validator Version:
Keywords: Cc:

Description

Interesting to have it in JOSM?

way[bridge] > node { set node_in_bridge; }
way[waterway] > node.node_in_bridge {
        throwWarning: tr("node must not connect waterway and bridge");
}

Attachments (0)

Change History (9)

comment:2 Changed 4 years ago by Aun Johnsen <lists@…>

What if first line is changed? Stopping the suggestion just because you don't like the syntax in the test is a little counter productive, lets try to improve this

way[railway][bridge] > node, way[highway][bridge] > node { set node_in_bridge; }

comment:3 Changed 4 years ago by Klumbumbus

Milestone: 15.02

I didn't stop the suggestion. However we should try to avoid to include validator checks which produce false positives because this makes the people ignoring the whole validator.

comment:4 Changed 4 years ago by jgpacker

It seems these false positive cases should be tagged with bridge=aqueduct.
So my suggestion would be to add an exception for this in the code, and also mention bridge=aqueduct in the warning message.

comment:5 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8089/josm:

fix #11127 - add validator warnings for waterway together with bridge=yes and node connecting waterway and bridge

comment:6 Changed 4 years ago by aceman

So this only warns if the bridge over a waterway shares a common node with the waterway?

comment:7 in reply to:  6 Changed 4 years ago by Klumbumbus

Replying to aceman:

So this only warns if the bridge over a waterway shares a common node with the waterway?

Yes, which should be the most common error case.

comment:8 Changed 4 years ago by aceman

Yes, that is fine.

I have a similar ticket #9304 for incorrectly connected highways. Maybe that can be implemented too now?

comment:9 in reply to:  8 Changed 4 years ago by Klumbumbus

Replying to aceman:

I have a similar ticket #9304 for incorrectly connected highways. Maybe that can be implemented too now?

I don't think this is possible with the current mapcss validator syntax. It would require atleast #10299. Or this is implemented via java code. (I'm not able to write Java code.)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.