[patch] Warn about missing parking=*

[skyper]

In addition to #10804 it would be nice if validator warns about missing parking=* on objects with amenity=parking*.

[Klumbumbus]

It would be info level only, since parking=* is an optional key.

[skyper]

patch

[skyper]

patch version 2

[skyper]

I added two patches. The first​ solves it in three lines while the second​ one might work with only one line. Please recheck as I am not familiar with mapcss-syntax, yet.

[skyper]

Replying to Klumbumbus:

It would be info level only, since parking=* is an optional key.

Ok, considering the presented text is it better to have three lines with the complete tag or one line which might need extra wording for better understanding.

[Klumbumbus]

Replying to skyper:

Ok, considering the presented text is it better to have three lines with the complete tag or one line which might need extra wording for better understanding.

three lines, because:

• no new text which needs to be translated into all languages is required
• validator does not warn for tags with typos, like amenity=parking_emtracne

Also validator should not recommend to add parking to parking_space.

[skyper]

patch version 3

[skyper]

The first two patches where wrong anyway ! Please, find correct patch version 3​ attached.

[skyper]

Replying to Klumbumbus:

Also validator should not recommend to add parking to parking_space.

Got you:
version 4​

[Klumbumbus]

There is a syntax error (at the end of line 121 in patch_v4). No need for v5. I fix it, when I apply it tonight.

[skyper]

patch version 4 without parking_space

[skyper]

Replying to Klumbumbus:

There is a syntax error (at the end of line 121 in patch_v4). No need for v5. I fix it, when I apply it tonight.

Just for learning I did replace josm_11126_v4.diff​ with a fixed version. Hope I finally got it right.

[Klumbumbus]

In 8080/josm:

fix #11126 - Info about missing parking=* (patch by Skyper)

[Klumbumbus]

Replying to skyper:

Hope I finally got it right.

Yes, except that you used throwWarning :)

[skyper]

Replying to Klumbumbus:

Replying to skyper:

Hope I finally got it right.

Yes, except that you used throwWarning :)

Damn it, just to much action around me. Thought I could easily provide a patch. Hopefully next time with some more concentration.