Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11126 closed enhancement (fixed)

[patch] Warn about missing parking=*

Reported by: skyper Owned by: team
Priority: normal Milestone: 15.02
Component: Core validator Version:
Keywords: parking Cc:

Description

In addition to #10804 it would be nice if validator warns about missing parking=* on objects with amenity=parking*.

Attachments (4)

josm_11126.diff (698 bytes) - added by skyper 4 years ago.
patch
josm_11126_v2.diff (608 bytes) - added by skyper 4 years ago.
patch version 2
josm_11126_v3.diff (991 bytes) - added by skyper 4 years ago.
patch version 3
josm_11126_v4.diff (946 bytes) - added by skyper 4 years ago.
patch version 4 without parking_space

Download all attachments as: .zip

Change History (17)

comment:1 Changed 4 years ago by Klumbumbus

It would be info level only, since parking=* is an optional key.

Changed 4 years ago by skyper

Attachment: josm_11126.diff added

patch

Changed 4 years ago by skyper

Attachment: josm_11126_v2.diff added

patch version 2

comment:2 Changed 4 years ago by skyper

I added two patches. The first solves it in three lines while the second one might work with only one line. Please recheck as I am not familiar with mapcss-syntax, yet.

comment:3 Changed 4 years ago by skyper

Summary: Warn about missing parking=*[patch] Warn about missing parking=*

comment:4 in reply to:  1 ; Changed 4 years ago by skyper

Replying to Klumbumbus:

It would be info level only, since parking=* is an optional key.

Ok, considering the presented text is it better to have three lines with the complete tag or one line which might need extra wording for better understanding.

comment:5 in reply to:  4 ; Changed 4 years ago by Klumbumbus

Replying to skyper:

Ok, considering the presented text is it better to have three lines with the complete tag or one line which might need extra wording for better understanding.

three lines, because:

  • no new text which needs to be translated into all languages is required
  • validator does not warn for tags with typos, like amenity=parking_emtracne

Also validator should not recommend to add parking to parking_space.

Changed 4 years ago by skyper

Attachment: josm_11126_v3.diff added

patch version 3

comment:6 Changed 4 years ago by skyper

The first two patches where wrong anyway ! Please, find correct patch version 3 attached.

comment:7 in reply to:  5 Changed 4 years ago by skyper

Replying to Klumbumbus:

Also validator should not recommend to add parking to parking_space.

Got you:
version 4

comment:8 Changed 4 years ago by Klumbumbus

Milestone: 15.02

comment:9 Changed 4 years ago by Klumbumbus

There is a syntax error (at the end of line 121 in patch_v4). No need for v5. I fix it, when I apply it tonight.

Changed 4 years ago by skyper

Attachment: josm_11126_v4.diff added

patch version 4 without parking_space

comment:10 in reply to:  9 ; Changed 4 years ago by skyper

Replying to Klumbumbus:

There is a syntax error (at the end of line 121 in patch_v4). No need for v5. I fix it, when I apply it tonight.

Just for learning I did replace josm_11126_v4.diff with a fixed version. Hope I finally got it right.

comment:11 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8080/josm:

fix #11126 - Info about missing parking=* (patch by Skyper)

comment:12 in reply to:  10 ; Changed 4 years ago by Klumbumbus

Replying to skyper:

Hope I finally got it right.

Yes, except that you used throwWarning :)

comment:13 in reply to:  12 Changed 4 years ago by skyper

Replying to Klumbumbus:

Replying to skyper:

Hope I finally got it right.

Yes, except that you used throwWarning :)

Damn it, just to much action around me. Thought I could easily provide a patch. Hopefully next time with some more concentration.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.