Modify

Opened 5 years ago

Closed 5 years ago

#10988 closed defect (fixed)

[patch] Add forward/backward roles for bicycle routes

Reported by: wiktorn Owned by: team
Priority: normal Milestone: 15.01
Component: Core validator Version: tested
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Validate a bicycle route with forward/backward role
  2. http://www.openstreetmap.org/way/31331416 is not accepted in relation http://www.openstreetmap.org/relation/1717308

What is the expected result?

No warnings

What happens instead?

Warning is raised: "Role forward uknown in templates" and "Role member type way does not match accepted list of way in template Bicycle Route (1)"

Please provide any additional information below. Attach a screenshot if possible.

Revision: 7906
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: Don-vip
Last Changed Date: 2014-12-29 00:13:58 +0100 (Mon, 29 Dec 2014)
Build-Date: 2014-12-29 00:11:17
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 7906

Identification: JOSM/1.5 (7906 en) Windows 7 64-Bit
Memory Usage: 978 MB / 3068 MB (412 MB allocated, but free)
Java version: 1.8.0_25, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Djava.security.manager, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.vmargs=LVhYOitVc2VHMUdDAC1EamF2YS51dGlsLkFycmF5cy51c2VMZWdhY3lNZXJnZVNvcnQ9dHJ1ZQA=, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.splashport=49846, -Djnlpx.home=<java.home>\bin, -Djnlpx.remove=false, -Djnlpx.offline=false, -Djnlpx.relaunch=true, -Djnlpx.session.data=C:\Users\w\AppData\Local\Temp\session2614516840692529838, -Djnlpx.heapsize=NULL,NULL, -Djava.security.policy=file:C:\Program Files\Java\jre1.8.0_25\lib\security\javaws.policy, -DtrustProxy=true]
Dataset consistency test: No problems found

Plugins:
- geotools (30762)
- jts (30762)
- opendata (30806)
- reverter (30737)
- utilsplugin2 (30863)

Attachments (2)

bicycle_forward_backward_defaultpresets.xml.patch (1.3 KB) - added by wiktorn 5 years ago.
patch fixing missing declarations
closedway_defaultpresets.xml.patch (3.5 KB) - added by wiktorn 5 years ago.
closedway for bicycle, mtb, hiking and detour routes

Download all attachments as: .zip

Change History (13)

Changed 5 years ago by wiktorn

patch fixing missing declarations

comment:1 Changed 5 years ago by wiktorn

for second problem, maybe we should use:

<role key="" text="route segment" type="way,closedway" [...]>

As roundabouts may come across a route. If so, this should be fixed for quite a few other relation types (detour route, hiking route for sure)

comment:2 in reply to:  1 Changed 5 years ago by skyper

Summary: Add forward/backward roles for bicycle routes[patch] Add forward/backward roles for bicycle routes

Thanks for the patch.
If attaching a patch, please always add [patch] at the beginning of the summary to get the ticket listed under report/8.

Replying to osm@…:

As roundabouts may come across a route. If so, this should be fixed for quite a few other relation types (detour route, hiking route for sure)

Roundabouts more and more get split into several pieces and a detour route which completely follows a roundabout seems strange form me.

+1 for hiking, as they often even include areas.

comment:3 Changed 5 years ago by Klumbumbus

Milestone: 15.01

comment:4 Changed 5 years ago by Klumbumbus

In 7971/josm:

see #10988 - applied patch. allow forward and backward roles for bicycle and mountain biking routes

comment:5 Changed 5 years ago by Klumbumbus

Split roundabout or not?
While I personally prefer to split it, the wiki says: "There is no consensus among the OSM community regarding which method is recommended."

So I think we should allow closedways as members of routes of type route=:

  • bicycle
  • mtb
  • hiking
  • detour

(route=road already allows closedway, see #10966)

Last edited 5 years ago by Klumbumbus (previous) (diff)

comment:6 Changed 5 years ago by mdk

This is a duplicate of #10979, but we should keep this, because it already has a patch and comments.

comment:7 Changed 5 years ago by Klumbumbus

Ticket #10979 has been marked as a duplicate of this ticket.

comment:8 Changed 5 years ago by anonymous

Yes, I've also seen roundabouts as members or routes (e.g. bus) and I see nothing wrong in it. Splitting it just for routes (with no other properties changed) seems unneeded and causes the bad side-effects in current OSM API (like loosing history). Also, JOSM relation editor shows routes containing roundabouts nicely connected.

Changed 5 years ago by wiktorn

closedway for bicycle, mtb, hiking and detour routes

comment:9 Changed 5 years ago by wiktorn

Even if there is no consesus, how to map roundabouts, still using closedway is correct one, therefore attached patch

comment:10 Changed 5 years ago by Klumbumbus

In 7974/josm:

see #10988 - applied patch. allow closedway (e.g. roundabouts) for bicycle, mtb, hiking and detour routes

comment:11 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.