Modify

Opened 5 years ago

Closed 4 years ago

#10980 closed defect (fixed)

Note download does not update already downloded notes

Reported by: Klumbumbus Owned by: ToeBee
Priority: normal Milestone: 15.04
Component: Core notes Version:
Keywords: template_report Cc: skyper

Description

What steps will reproduce the problem?

  1. Download some notes
  2. add a comment and/or close a previous downloaded note via osm.org
  3. download in JOSM this area again

What is the expected result?

The external modified note get updated.

What happens instead?

Neither the new comment nor the closed state of the external modified note is displayed in JOSM.

Please provide any additional information below. Attach a screenshot if possible.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-01-15 02:34:56
Last Changed Author: Klumbumbus
Revision: 7967
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-01-15 00:47:55 +0100 (Thu, 15 Jan 2015)
Last Changed Rev: 7967

Identification: JOSM/1.5 (7967 en) Windows 7 32-Bit
Memory Usage: 387 MB / 742 MB (148 MB allocated, but free)
Java version: 1.7.0_71, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files\Java\jre7\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=61808, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Plugins:
- DirectUpload (30892)
- HouseNumberTaggingTool (30892)
- OpeningHoursEditor (30892)
- PicLayer (30892)
- Tracer2 (30892)
- buildings_tools (30892)
- download_along (30892)
- editgpx (30892)
- imagery_offset_db (30892)
- measurement (30892)
- mirrored_download (30892)
- notes (v0.9.5)
- public_transport (30892)
- reltoolbox (30892)
- reverter (30892)
- tag2link (30892)
- terracer (30892)
- turnrestrictions (30892)
- undelete (30892)
- utilsplugin2 (30892)
- wikipedia (30892)

Last errors/warnings:
- W: TMS - Failed downloading http://ecn.t3.tiles.virtualearth.net/tiles/a12021221001201.jpeg?g=3089: Attribution is not loaded yet
- W: TMS - Failed downloading http://ecn.t0.tiles.virtualearth.net/tiles/a12021221001003.jpeg?g=3089: Attribution is not loaded yet
- W: TMS - Failed downloading http://ecn.t3.tiles.virtualearth.net/tiles/a12021221001002.jpeg?g=3089: Attribution is not loaded yet
- W: TMS - Failed downloading http://ecn.t1.tiles.virtualearth.net/tiles/a12021221000311.jpeg?g=3089: Attribution is not loaded yet
- W: TMS - Failed downloading http://ecn.t2.tiles.virtualearth.net/tiles/a12021221001020310210.jpeg?g=3089: Read timed out

Attachments (0)

Change History (14)

comment:1 Changed 5 years ago by skyper

Ticket #10981 has been marked as a duplicate of this ticket.

comment:2 Changed 5 years ago by skyper

Cc: skyper added

Do not forget to make the warning more user friendly if you try to upload a note which was changed in between your download-upload-cycle.

comment:3 Changed 5 years ago by skyper

@Klumbumbus:
Not sure if it is smart to use the notes plugin and the internal core support at the same time. Might lead to unexpected collisions.

comment:4 in reply to:  3 Changed 5 years ago by Klumbumbus

Replying to skyper:

@Klumbumbus:
Not sure if it is smart to use the notes plugin and the internal core support at the same time. Might lead to unexpected collisions.

The plugin is installed but I do not use it (toggle Dialog closed). So it should not make problems.

comment:5 Changed 5 years ago by Don-vip

Component: CoreCore notes

Moving notes tickets to their own component

comment:6 Changed 5 years ago by Don-vip

Keywords: notes removed

comment:7 Changed 5 years ago by simon04

Is there a reason why already downloaded notes are skipped in org.openstreetmap.josm.data.osm.NoteData#addNotes?

comment:8 Changed 5 years ago by simon04

Milestone: 15.04

comment:9 in reply to:  7 ; Changed 5 years ago by skyper

Replying to simon04:

Is there a reason why already downloaded notes are skipped in org.openstreetmap.josm.data.osm.NoteData#addNotes?

Is there any conflict solution for notes implemented yet ?

What happens if I redownload and have locally modified some notes but not yet uploaded ?

comment:10 in reply to:  9 Changed 5 years ago by simon04

Replying to skyper:

Is there any conflict solution for notes implemented yet ?

ASAIK no.

What happens if I redownload and have locally modified some notes but not yet uploaded ?

In this case we could keep the local version, i.e., stay with the current behaviour.

comment:11 Changed 5 years ago by simon04

In 8224/josm:

see #10980 - Note download: update already downloaded non-modified notes; use Storage for internal storage

comment:12 Changed 5 years ago by simon04

To be discussed: In case of a locally modified note (i.e., with a non committed comment), we could merge the comments based on the date …

comment:13 in reply to:  12 ; Changed 4 years ago by skyper

Replying to simon04:

To be discussed: In case of a locally modified note (i.e., with a non committed comment), we could merge the comments based on the date …

Personally, I would prefer a warning and an option to compare, as you can still delete or adjust your own comment/resolution.

Maybe, it makes sense to even somehow highlight any changed note to have a look at it.

comment:14 in reply to:  13 Changed 4 years ago by simon04

Resolution: fixed
Status: newclosed

The note comment merging part is split to #11368, so this ticket is fixed. :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ToeBee.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.