Use ID for imagery sources in toolbar, image offsets and source-entry for uploads instead of name

[rickmastfan67]

Just today, somebody updated the 'Tiger 2013' entry for the imagery map to the 'Tiger 2014'. ( ​http://josm.openstreetmap.de/wiki/Maps/USA?action=diff&version=12 ) I already had the 'Tiger 2013' stored in my toolbar so I would have one click access to it if I needed it while mapping. So, when JOSM automatically updated the imagery list at startup, it broke the toolbar entry for the 'Tiger 2013' imagery instead of updating it to the 'Tiger 2014 automatically.

Since the info change was on the same line, I would have expected JOSM to update my toolbar entry for it. Would there be anyway in the future to allow this to happen without me having to re-add the 'updated' year version?

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-12-05 02:34:20
Last Changed Author: Don-vip
Revision: 7764
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-12-05 01:10:47 +0100 (Fri, 05 Dec 2014)
Last Changed Rev: 7764

Identification: JOSM/1.5 (7764 en) Windows 7 64-Bit
Memory Usage: 222 MB / 1820 MB (110 MB allocated, but free)
Java version: 1.7.0_71, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM

Plugins:
- ImageryCache (30738)
- OpeningHoursEditor (30737)
- buildings_tools (30762)
- measurement (30737)
- mirrored_download (30762)
- notes (v0.9.5)
- osmarender (30738)
- reverter (30737)
- turnrestrictions (30762)
- undelete (30762)
- utilsplugin2 (30762)

[stoecker]

So, when JOSM automatically updated the imagery list at startup, it broke the toolbar entry for the 'Tiger 2013' imagery instead of updating it to the 'Tiger 2014 automatically.

How? Was it unaccesible (based on the old name)?

[rickmastfan67]

There was a 'toolbar' error and the icon in the toolbar for it disappeared. Had to manually add back the new '2014' version of it. Wish I would have saved a copy of the error in the CL, but didn't.

[stoecker]

Hmm, maybe we should switch to the entry id for toolbar name when existing. But this needs an fallback for old entries.

[Don-vip]

move tickets that have not been treated this month to next milestone

[rickmastfan67]

Just happened again with the Tiger 2014 layer because somebody tweaked the name for it. :(

And yes, it was un-accessible because of the old name. It threw up errors in the CL about there being no definition for the tool bar entry. Kinda like INFO: Could not load tool definition *** and had the old imagery name for that layer. Also, the icon for it was gone in the toolbar.

Anyways, this just seems to be a problem for entries that are added from the wiki database to the toolbar. Doesn't seem to effect entries you've personally manually added to the 'local' list.

[stoecker]

Ticket #11041 has been marked as a duplicate of this ticket.

[stoecker]

Id should not only be used for toolbar, but also for imagery offsets.

[aceman]

Where can I get the ID so I can edit the config file to make offsets match again and visible?

[stoecker]

That's nothing you can do. We need to adapt source. In the past our maps data had no specific ID, so we used the name instead. For these where we now have an ID, we need to use it instead of the name, so name changes do no harm.

[StefanB]

Also consider using the id in URL parameter: https://josm.openstreetmap.de/mapsview?entry=ID
instead of name, as it is now: https://josm.openstreetmap.de/mapsview?entry=NAME
(linked from wiki page Maps)

[stoecker]

Move one month.

[simon04]

Using the id for the toolbar is as simple as changing org.openstreetmap.josm.data.imagery.ImageryInfo#getToolbarName. Then however the old toolbar icons will no longer work. Implementing a migration process is more complex …

[stoecker]

Me need to support both methods anyway, as not all maps have an ID.

[aceman]

For those use the (untranslated) name as the ID?

[Don-vip]

skip milestone 15.06

[Don-vip]

Milestone renamed

[Don-vip]

removing from milestone as it seems nobody's working on it right now.

[rickmastfan67]

And it happened once again when the entry for the Tiger data had the date changed from 2014 to 2015.

https://josm.openstreetmap.de/wiki/Maps/USA?version=17

Did capture the exact error that showed up this time unlike in comment:6.
INFO: Could not load tool definition imagery_New & Misaligned TIGER Roads \(2014\)

Using r8692.