Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10812 closed enhancement (fixed)

[patch] Geo Tagged Images popup should show path

Reported by: amenk Owned by: amenk
Priority: normal Milestone: 14.12
Component: Core image mapping Version: tested
Keywords: Cc:

Description

When loading lots pictures with identical names but different paths we can not determine the on-disk path of a picture from the popup dialog.
The path should be shown somewhere or a function offered to copy the full path + name

Attachments (2)

patch10812.patch (5.5 KB) - added by amenk 5 years ago.
Patch implementing a copy path functionality
patch10812-v2.patch (4.0 KB) - added by amenk 5 years ago.
revised patch

Download all attachments as: .zip

Change History (10)

comment:1 Changed 5 years ago by amenk

Another useful (similar) feature would be to add the image path to the "source:ref" tag (with a prefix) - as we would upload the images to our webserver.

Changed 5 years ago by amenk

Attachment: patch10812.patch added

Patch implementing a copy path functionality

comment:2 Changed 5 years ago by bastiK

Milestone: 14.12
Summary: Geo Tagged Images popup should show path[patch] Geo Tagged Images popup should show path

Thanks for the patch, it will be applied after the current release.

Please read your patch carefully before submitting and make sure, it doesn't include any unrelated changes. The * import should be expanded.

comment:3 Changed 5 years ago by Don-vip

Owner: changed from team to amenk
Status: newneedinfo

Thanks for the patch. As said it requires some cleaning:

  • MainApplication.java and TMSLayer.java must not be modified
  • the import java.awt.datatransfer.* must be expanded
  • the indentation must be OK, with spaces only
  • there's a big problem with the code copied&pasted as it modifies the delete button, not the new button you want to add:
    btnDeleteFromDisk.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(scCopyPath.getKeyStroke(), ACOPYPATH);
    btnDeleteFromDisk.getActionMap().put(ADELFROMDISK, copyPathAction);
    

Changed 5 years ago by amenk

Attachment: patch10812-v2.patch added

revised patch

comment:4 Changed 5 years ago by amenk

I attached the revised patch - hope everything is okay now.

comment:5 Changed 5 years ago by bastiK

Resolution: fixed
Status: needinfoclosed

In 7788/josm:

applied #10812 - new copy path feature for geotagged image dialog (patch by alex.menk, slighly modified)

comment:6 Changed 5 years ago by bastiK

Thanks for the patch!

I've removed the shortcut as I think it is not needed and might conflict with the ability to copy text elsewhere in the application.

comment:7 Changed 5 years ago by bastiK

In 7789/josm:

see #10812 - add shortcut back

comment:8 Changed 5 years ago by bastiK

Okay I didn't read it properly. As the suggested shortcut is Ctrl+Alt+Shift+C, this should be fine.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain amenk.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.