Modify

Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#10752 closed enhancement (wontfix)

Use name-suggestion-index

Reported by: Math1985 Owned by: team
Priority: normal Milestone: 15.02
Component: Core Version:
Keywords: Cc:

Description

name-suggestion-index [1] is a list of commonly used name values for suggesting correct spelling of name tags. It can also help automatically suggesting the correct shop tag given the name.

It has been already implemented in iD [2].

Would it be an idea to implement this in JOSM as well? I can imagine it would take quite some coding to do this, but I think it would be really useful if implemented. Inconsistent shop names are a common problem, and hard to correct [3].

[1] https://github.com/osmlab/name-suggestion-index
[2] https://www.mapbox.com/blog/common-names-in-id/
[3] https://wiki.openstreetmap.org/wiki/Mechanical_Edits/Math1985/UK_Shop_Names

Attachments (0)

Change History (8)

comment:1 Changed 8 years ago by Math1985

Type: defectenhancement

comment:2 Changed 8 years ago by stoecker

Hmm, when I look at the list I'm not so sure if it is really an improvement:

E.g. "shop/butcher|Мясо" --> Мясо means "meat"
"amenity/arts_centre|Дом культуры" --> means Arts centre
"amenity/pharmacy|аптека" --> means pharmacy

and so on. If we do suggestions they should at least better than what we do already (which is suggest entries in the local area).

comment:3 Changed 8 years ago by anonymous

I think you are looking at the unfiltered list. https://github.com/osmlab/name-suggestion-index/blob/master/name-suggestions.json is the filtered list which is supposed to be used in external software.

comment:4 Changed 8 years ago by stoecker

Even there. Two different names for "Aldi süd", two for "Aldi nord" and an "ALDI", two names for "real". "Продукты", "продукты" and "Продукти" for convenience, two different for "dm" and so on.

I think the idea is probably good, but not the quality.

comment:5 in reply to:  4 Changed 8 years ago by bastiK

Replying to stoecker:

Even there. Two different names for "Aldi süd", two for "Aldi nord" and an "ALDI", two names for "real". "Продукты", "продукты" and "Продукти" for convenience, two different for "dm" and so on.

Depending on our implementation, this will simply not be helpful in these cases, but also do no harm.

I think the idea is probably good, but not the quality.

Can be improved. I think it is good enough to include it in the auto-suggestion. To be save, it could have lower priority than what is currently in the downloaded data, although this defeats the purpose :) .

comment:6 Changed 8 years ago by stoecker

Milestone: 15.02

Let's see if quality improves. Postponing some months.

comment:7 Changed 8 years ago by stoecker

Resolution: wontfix
Status: newclosed

No improvements.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.