Modify

Opened 2 years ago

Last modified 5 weeks ago

#15217 new enhancement

Use name-suggestion-index

Reported by: mkoniecz Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report name brand Cc: 1ec5, aharvey

Description

name-suggestion-index [1] is a list of commonly used name values for suggesting correct spelling of name tags. It can also help automatically suggesting the correct shop tag given the name.

It has been already implemented in iD [2] and Vespucci [3].

Would it be an idea to implement this in JOSM as well? I can imagine it would take quite some coding to do this, but I think it would be really useful if implemented. Inconsistent shop names are a common problem, and hard to correct [4].

[1]https://github.com/osmlab/name-suggestion-index
[2]https://www.mapbox.com/blog/common-names-in-id/
[3] http://vespucci.io/tutorials/name_suggestions/
[4]https://wiki.openstreetmap.org/wiki/Mechanical_Edits/Math1985/UK_Shop_Names

Note that it is a resurrection of https://josm.openstreetmap.de/ticket/10752

10752 was closed three years ago as wontfix for reasons that seems to be fixed from looking at https://github.com/osmlab/name-suggestion-index/blob/master/canonical.json and https://github.com/osmlab/name-suggestion-index/blob/master/filter.json

Attachments (0)

Change History (12)

comment:1 Changed 2 years ago by stoecker

Situation got better compared to 3 years ago, but I still find many generics in the lists, especially when it comes to non-latin names.

But as suggestion it may now have a value.

comment:2 Changed 2 years ago by kocio

Even if there are generics, but the names are consistent, it's easier to find them and fix later. And it's not easy to tell if the name is generic or not (if there's a banner above the doors it may be both).

Last edited 2 years ago by kocio (previous) (diff)

comment:3 Changed 2 years ago by mkoniecz

"but I still find many generics in the lists, especially when it comes to non-latin names" can you maybe give examples? Either here or as an issues at https://github.com/osmlab/name-suggestion-index/issues ?

Even if it will not be used in JOSM fixing this issues will improve quality of data from iD where this data is already used.

comment:4 Changed 2 years ago by kocio

Are there additional questions or plans about this ticket? I'm interested to have this functionality in JOSM, because it's my editor of choice.

comment:5 Changed 2 years ago by bastiK

The plan is to wait for someone to implement this feature.

comment:6 Changed 22 months ago by maxerickson@…

The half measure of creating a preset for each suggestion (available as name-suggestions.presets.xml in the name suggestion repo already) at least makes the names available in the F3 search and for autocomplete.

I've hesitated to add the file to the preset list on the wiki because it uses the one click style presets.

comment:7 Changed 19 months ago by mkoniecz

I've hesitated to add the file to the preset list on the wiki because it uses the one click style presets.

Why it is a bad thing?

comment:8 Changed 19 months ago by maxerickson@…

With the one click style presets there is little indication that the tags have been changed. A dialog gives the chance to preview the new tags and cancel and so on.

comment:9 Changed 14 months ago by 1ec5

Cc: 1ec5 added

comment:10 Changed 3 months ago by Don-vip

Keywords: name brand added

comment:11 Changed 5 weeks ago by aharvey

It would be nice if JOSM could do suggested tag updates based on the name-suggestion-index like how iD, especially for brand and brand:wikdata tags. I prefer to use JOSM, but the brand suggested tag updates is something iD does well.

I think a UI similar to the conflicts UI where you can see the suggested changes and approve or ignore specific tags.

comment:12 Changed 5 weeks ago by aharvey

Cc: aharvey added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to mkoniecz
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.