Opened 9 years ago

Closed 9 years ago

#10594 closed enhancement (fixed)

Synonymous values in the shop key

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 14.10
Component: Core validator Version:
Keywords: template_report shop Cc:

Description (last modified by Don-vip)

Some shop values are obvious duplicates of more commonly used, documented values. I confirmed that in these examples values are really synonymous by discussion on tagging mailing list (under title "Synonymous values in the shop key").

I attach proposed validator rules and testcase.

*[shop=bags] {
  throwWarning: tr("{0}={1} is deprecated", "{0.key}", "{0.value}");
  fixAdd: "shop=bag";
  assertMatch: "way shop=bag";
  assertNoMatch: "way barrier=fence";

*[shop=antique] {
  throwWarning: tr("{0}={1} is deprecated", "{0.key}", "{0.value}");
  fixAdd: "shop=antiques";
  assertMatch: "way shop=antique";
  assertNoMatch: "way shop=antiques";

*[shop=pets] {
  throwWarning: tr("{0}={1} is deprecated", "{0.key}", "{0.value}");
  fixAdd: "shop=pet";
  assertMatch: "way shop=pets";
  assertNoMatch: "way shop=pet";

*[shop=pharmacy] {
  throwWarning: tr("{0}={1} is deprecated", "{0.key}", "{0.value}");
  fixAdd: "amenity=pharmacy";
  fixRemove: "shop";
  assertMatch: "way shop=pharmacy";
  assertNoMatch: "way amenity=pharmacy";
Repository Root:
Build-Date: 2014-10-05 01:34:55
Last Changed Author: Don-vip
Revision: 7599
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
Last Changed Date: 2014-10-05 01:24:20 +0200 (Sun, 05 Oct 2014)
Last Changed Rev: 7599

Identification: JOSM/1.5 (7599 en) Linux Ubuntu 14.04.1 LTS
Memory Usage: 218 MB / 721 MB (74 MB allocated, but free)
Java version: 1.7.0_67, Oracle Corporation, Java HotSpot(TM) Server VM

- ImportImagePlugin (30416)
- OpeningHoursEditor (30609)
- PicLayer (30436)
- buildings_tools (30485)
- geotools (30569)
- jts (30416)
- log4j (30416)
- measurement (30641)
- notes (v0.9.4)
- turnrestrictions (30651)

Attachments (1)

shop_testcase.osm (1.1 KB ) - added by mkoniecz 9 years ago.

Download all attachments as: .zip

Change History (4)

by mkoniecz, 9 years ago

Attachment: shop_testcase.osm added

comment:1 by Don-vip, 9 years ago

Description: modified (diff)

comment:2 by Don-vip, 9 years ago

Keywords: shop added
Milestone: 14.10

comment:3 by Don-vip, 9 years ago

Resolution: fixed
Status: newclosed

In 7600/josm:

fix #10594 - add deprecation warnings for synonymous shop values + add preset/icon for shop=antiques

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.