Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10483 closed enhancement (fixed)

Multi thread data consistency test and more enhancement

Reported by: skyper Owned by: team
Priority: normal Milestone: 14.09
Component: Core Version:
Keywords: consistency test multi core performance Cc:

Description

Please, have the data consistency test run in multi thread on multi-core machines.

Some more enhancement:

  • show the time the test took like validator in the console
  • allow to send it in background and allow to work on other layers + download to new layers.

See #10488 for an example file.

Attachments (0)

Change History (7)

comment:1 Changed 5 years ago by Don-vip

Keywords: consistency performance added; consitency removed

comment:2 Changed 5 years ago by Don-vip

Milestone: 14.09

comment:3 Changed 5 years ago by Don-vip

In 7500/josm:

see #10483 - print elapsed time of data consistency test + update javadoc

comment:4 Changed 5 years ago by Don-vip

"Search ways" appears to be very slow:

DEBUG: Test 'DatasetConsistencyTest.referredPrimitiveNotInDataset' completed in 513 ms
DEBUG: Test 'DatasetConsistencyTest.checkReferrers' completed in 376 ms
DEBUG: Test 'DatasetConsistencyTest.checkCompleteWaysWithIncompleteNodes' completed in 163 ms
DEBUG: Test 'DatasetConsistencyTest.checkCompleteNodesWithoutCoordinates' completed in 186 ms
DEBUG: Test 'DatasetConsistencyTest.searchNodes' completed in 2.9 s
DEBUG: Test 'DatasetConsistencyTest.searchWays' completed in 1 min 17 s
DEBUG: Test 'DatasetConsistencyTest.checkZeroNodesWays' completed in 147 ms
DEBUG: Test 'DatasetConsistencyTest.runTest' completed in 1 min 22 s

comment:5 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7501/josm:

fix #10483 - drastic improvement of data consistency test performance

comment:6 Changed 5 years ago by Don-vip

Much better now:

DEBUG: Test 'DatasetConsistencyTest.referredPrimitiveNotInDataset' completed in 558 ms
DEBUG: Test 'DatasetConsistencyTest.checkReferrers' completed in 409 ms
DEBUG: Test 'DatasetConsistencyTest.checkCompleteWaysWithIncompleteNodes' completed in 169 ms
DEBUG: Test 'DatasetConsistencyTest.checkCompleteNodesWithoutCoordinates' completed in 181 ms
DEBUG: Test 'DatasetConsistencyTest.searchNodes' completed in 1.5 s
DEBUG: Test 'DatasetConsistencyTest.searchWays' completed in 287 ms
DEBUG: Test 'DatasetConsistencyTest.checkZeroNodesWays' completed in 149 ms
DEBUG: Test 'DatasetConsistencyTest.runTest' completed in 3.3 s

comment:7 Changed 5 years ago by Don-vip

In 7502/josm:

see #10483 - fix error message

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.