Modify

Opened 5 years ago

Last modified 3 years ago

#10429 new defect

false warnings about role:"number" and forward/backward:stop for public transport routes

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: public-transport-v1 role Cc: simon04

Description

Since adding public_transport:version=* I get tons of warning about stop:[number] and similar though it is written on the wiki for years that colon separated numbers behind the role is allowed.

For version 1 forward/backward are also valid.

Attachments (2)

Bus_12.osm.gz (9.4 KB) - added by skyper 5 years ago.
sample version=2
Bus_7208.1.osm.gz (89.7 KB) - added by skyper 5 years ago.
sample version=1

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by Don-vip

Owner: changed from team to skyper
Status: newneedinfo

can you please attach a sample file? Thanks.

comment:2 in reply to:  1 Changed 5 years ago by skyper

Owner: changed from skyper to team
Status: needinfonew

Replying to Don-vip:

can you please attach a sample file? Thanks.

Please, just have a look at my last changeset. Should be enough.

comment:3 Changed 5 years ago by Don-vip

I will tomorrow if I find some time, but please note:

  • we have a thousand tickets to look after and a small .osm extract is the fastest way for us to understand and fix a problem. For example, #10416 was very easy/fast
  • objects listed in a changeset are subject to further change between the time you create a ticket and the time we fix it. It can be be minutes or years... ;)

Changed 5 years ago by skyper

Attachment: Bus_12.osm.gz added

sample version=2

Changed 5 years ago by skyper

Attachment: Bus_7208.1.osm.gz added

sample version=1

comment:4 in reply to:  3 Changed 5 years ago by skyper

Replying to Don-vip:

I will tomorrow if I find some time, but please note:

  • we have a thousand tickets to look after and a small .osm extract is the fastest way for us to understand and fix a problem. For example, #10416 was very easy/fast
  • objects listed in a changeset are subject to further change between the time you create a ticket and the time we fix it. It can be be minutes or years... ;)

Sorry, was a bit lazy and thought my description and Relation:route#Members is enough. Think it is possible to download a specific version of an object but you are right that it makes it more complicated and time consuming.

I attached as "version=2" example relation/69434 as Bus_12.osm.gz and as "version=1" example relation/68320 as Bus_7208.1.osm.gz.

comment:5 Changed 5 years ago by Don-vip

Cc: simon04 added

Simon: where is public_transport:version used? I don't find any reference to it besides the validator warning asking for its presence?

comment:6 Changed 5 years ago by skyper

public_transport:version should be used to find the proper tests. Without it the tests about proper roles are not run at all, but I did not test if it the value makes any difference, so far.

comment:7 in reply to:  description Changed 5 years ago by skyper

Summary: false warnings about role:"number" and forward/backward for public transport routesfalse warnings about role:"number" and forward/backward:stop for public transport routes

Replying to skyper:

For version 1 forward/backward are also valid.

I meant `forward:stop[:number] but the above is true, as well.

comment:8 Changed 4 years ago by simon04

Keywords: public-transport-v1 added; public transport removed

comment:9 Changed 3 years ago by skyper

The roles are documented for ages at the wiki and it is the only way to get JOSM to sort the relation the right way.

I get tons of these warnings (~ 90% of all warnings) which makes it hard to find warnings about other relation types and real problems.

Last edited 3 years ago by skyper (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to skyper
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.