One false + one missing warning about conditional tag

[skyper]

Please, have a look at attached sample file​.

• the node raises a warning but I do not find a problem.
• the way does not raise a warning though it is wrong (forward and conditional need to be changed).

Please provide any additional information below. Attach a screenshot if
possible.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-08-22 01:36:32
Last Changed Author: Don-vip
Revision: 7437
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-08-22 00:58:24 +0200 (Fri, 22 Aug 2014)
Last Changed Rev: 7437

Identification: JOSM/1.5 (7437 en) Linux Debian GNU/Linux 7.6 (wheezy)
Memory Usage: 557 MB / 882 MB (112 MB allocated, but free)
Java version: 1.7.0_65, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u65-2.5.1-2~deb7u1
Dataset consistency test: No problems found

Plugins:
- OpeningHoursEditor (30519)
- conflation (0.1.7)
- imagery-xml-bounds (30495)
- jts (30416)
- mirrored_download (30495)
- notes (v0.9.3)
- photoadjust (30428)
- reverter (30521)
- terracer (30416)
- todo (29154)
- undelete (30416)
- utilsplugin2 (30460)
- wikipedia (30449)

Last errors/warnings:
- W: Detected deprecated 'canvas{background-color}' in 'https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip' which will be removed shortly. Use 'fill-color' instead.

[skyper]

sample file

[Don-vip]

stay is undocumented. maxstay is documented and used more, I propose to add this one instead to the list of known restrictions.

[Don-vip]

In 7445/josm:

fix #10416 - conditional keys: add maxstay restriction + detect another case of invalid syntax

[skyper]

preset patch

[skyper]

preset patch version 2

[skyper]

Replying to Don-vip:

stay is undocumented. maxstay is documented and used more, I propose to add this one instead to the list of known restrictions.

Well, I used the preset. Please, find attached patch​ to adjust the preset. I am not happy with these long units though.

As stay was supported by JOSM a validator warning to better use maxstay with adjusted value instead would be nice.

[Don-vip]

In 7449/josm:

see #10416 - replace undocumented stay key by maxstay, used more

[skyper]

Replying to Don-vip:

In 7449/josm:

see #10416 - replace undocumented stay key by maxstay, used more

I am not happy with the values. On the ​wiki there is no default unit defined and the proposal + most used values have units.

Default unit should be hour and not minute and I would prefer to use abbreviations for units but this needs further discussion I guess.

[Don-vip]

hh:mm could also do the job. This format is used for duration:
​https://taginfo.openstreetmap.org/keys/?key=duration#values

[skyper]

Replying to Don-vip:

hh:mm could also do the job. This format is used for duration:
​https://taginfo.openstreetmap.org/keys/?key=duration#values

Does not need a huge time span but we minutes, hours and days probably not years. Duration will need these units once we map the routes to the moon or other planets but maxstay=720:00 is not nicely human readable and error-prone value compared to 30d