#10289 closed enhancement (fixed)
[patch] Power generator update, separated by source
| Reported by: | skyper | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 14.08 |
| Component: | Internal preset | Version: | |
| Keywords: | power generator | Cc: | geozeisig, francois.lacombe@… |
Description
As mentioned on #8881, there was the idea to split the preset for power=generator to have an own presets for each power:source.
Please, find attached a first version of a patch. I did adjust values for generator:type and generator:method accordingly but I was unsure about restricting power:output:*=*.
Attachments (2)
Change History (11)
by , 10 years ago
| Attachment: | power_generator.diff added |
|---|
comment:1 by , 10 years ago
| Cc: | added |
|---|
follow-up: 4 comment:2 by , 10 years ago
Great :)
I think the wording of items can be improved. Instead of having "XXXX Power Generator" we can use conventional names when applicable.
Example: in the power generator group, have items named:
- Nuclear reactor
- Gas turbine
- Water turbine
- etc.
comment:3 by , 10 years ago
| Milestone: | → 14.08 |
|---|
comment:4 by , 10 years ago
Replying to Don-vip:
I think the wording of items can be improved. Instead of having "XXXX Power Generator" we can use conventional names when applicable.
Example: in the power generator group, have items named:
- Nuclear reactor
- Gas turbine
- Water turbine
- etc.
I get your point. The repetition is not nice.
The problem is that there are still different generator:type and generator:method. E.g. I cannot use "turbine" if it can be a steam_generator with is true for almost all combustion generator. Similar is true for water. I can adjust one or two like "wind" and "nuclear" but not many.
comment:5 by , 10 years ago
follow-up: 9 comment:8 by , 10 years ago
Thanks for implementing this in JOSM. Please delete the Preset Generator nach source sortiert. There are only es few details left.
comment:9 by , 10 years ago
Replying to geozeisig:
Thanks for implementing this in JOSM. Please delete the Preset Generator nach source sortiert. There are only es few details left.
Is there any way to archive outdated presets and styles ?
It is possible to add outdated in the header of the page but how to stop the delivery of the file ? I do not just want to delete the page which might be ok for this external preset but not for all deprecated external styles and presets.
patch