NPE testing defaultpreset without data layer

[skyper]

What steps will reproduce the problem?

Start plugin without data layer with little changed defaultpreset.xml

What is the expected result?

Tagging-preset-tester window opens.

What happens instead?

NPE

Please provide any additional information below. Attach a screenshot if possible.

It works with existing data layer. Probably similar or duplicate of #10055. Please find the test file​ attached.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-07-20 01:36:10
Last Changed Author: stoecker
Revision: 7318
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-07-19 21:12:28 +0200 (Sat, 19 Jul 2014)
Last Changed Rev: 7318

Identification: JOSM/1.5 (7318 de) Linux Debian GNU/Linux 7.6 (wheezy)
Memory Usage: 107 MB / 882 MB (31 MB allocated, but free)
Java version: 1.7.0_55, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u55-2.4.7-1~deb7u1
VM arguments: [-Djosm.home=$HOME/.josm-test]

Plugin: tagging-preset-tester (30416)

java.lang.NullPointerException
	at org.openstreetmap.josm.gui.tagging.TaggingPresetSelector.filterPresets(TaggingPresetSelector.java:327)
	at org.openstreetmap.josm.gui.tagging.TaggingPresetSelector.<init>(TaggingPresetSelector.java:295)
	at org.openstreetmap.josm.plugins.taggingpresettester.TaggingPresetTester.<init>(TaggingPresetTester.java:70)
	at org.openstreetmap.josm.plugins.taggingpresettester.TaggingPresetTesterAction.actionPerformed(TaggingPresetTesterAction.java:48)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2018)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2341)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.AbstractButton.doClick(AbstractButton.java:376)
	at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:833)
	at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:877)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
	at java.awt.Component.processMouseEvent(Component.java:6505)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3311)
	at java.awt.Component.processEvent(Component.java:6270)
	at java.awt.Container.processEvent(Container.java:2229)
	at java.awt.Component.dispatchEventImpl(Component.java:4861)
	at java.awt.Container.dispatchEventImpl(Container.java:2287)
	at java.awt.Component.dispatchEvent(Component.java:4687)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4832)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4492)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4422)
	at java.awt.Container.dispatchEventImpl(Container.java:2273)
	at java.awt.Window.dispatchEventImpl(Window.java:2719)
	at java.awt.Component.dispatchEvent(Component.java:4687)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:735)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:694)
	at java.awt.EventQueue$3.run(EventQueue.java:692)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.awt.EventQueue$4.run(EventQueue.java:708)
	at java.awt.EventQueue$4.run(EventQueue.java:706)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:705)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

[skyper]

test file

[akks]

Should be fixed in [o30541]

Sorry, the bug was in JOSM code. Fixing...

[akks]

In 7322/josm:

fix #10288: tagging-preset-tester NPE without data layer

[Don-vip]

In 7324/josm:

see #10288 - fix compilation warning