Modify

Opened 5 years ago

Closed 4 years ago

#10290 closed defect (fixed)

inconsistency rendering direction arrows for waterways

Reported by: skyper Owned by: team
Priority: normal Milestone: 16.02
Component: Internal mappaint style Version: latest
Keywords: waterway direction arrow Cc:

Description

There is at least an inconsistency in rendering direction arrows for waterway=*:

  • while canal is rendered with arrows (upper)
  • ditch is rendered without arrows (lower)

screenshot

Please turn it around and do not render arrows for canals as they may have been tagged with oneway=*, too.

Recently there was a dicussion proposing a new tag flow_direction=forward/backward/both/none for man_mad=pipeline and waterway=* as oneway=* is an access condition.

This somehow reminds my about the discussion about rendering incline=*.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-07-21 01:35:49
Last Changed Author: Don-vip
Revision: 7321
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-07-21 01:51:53 +0200 (Mon, 21 Jul 2014)
Last Changed Rev: 7321

Identification: JOSM/1.5 (7321 en) Linux Debian GNU/Linux 7.6 (wheezy)
Memory Usage: 517 MB / 882 MB (260 MB allocated, but free)
Java version: 1.7.0_55, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u55-2.4.7-1~deb7u1
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (30519)
Plugin: conflation (0.1.7)
Plugin: imagery-xml-bounds (30495)
Plugin: jts (30416)
Plugin: mirrored_download (30495)
Plugin: notes (v0.9.2)
Plugin: photoadjust (30428)
Plugin: reverter (30521)
Plugin: terracer (30416)
Plugin: todo (29154)
Plugin: undelete (30416)
Plugin: utilsplugin2 (30460)
Plugin: wikipedia (30449)

Attachments (1)

waterway.png (1.9 KB) - added by skyper 5 years ago.
screenshot

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by skyper

Attachment: waterway.png added

screenshot

comment:1 Changed 5 years ago by skyper

Forgot:

  • wadi usually have a flow direction and it would be consistent to render arrows

comment:2 Changed 4 years ago by skyper

This is inconsistent compared to validator, which warns about changing direction of any waterway=*.

comment:3 Changed 4 years ago by simon04

In 9538/josm:

see #10290 - Consider waterway=canal as not directional, waterway=ditch|wadi as directional

comment:4 Changed 4 years ago by simon04

Resolution: fixed
Status: newclosed

In 9539/josm:

fix #10290 - Improve ReverseWayNoTagCorrector

It evaluates its own directional tags together with those defined at
OsmPrimitive#directionKeys minus the ones that can be corrected using
ReverseWayTagCorrector.

comment:5 Changed 4 years ago by simon04

Milestone: 16.02

comment:6 Changed 4 years ago by aceman

I think wadi was obsoleted (on wiki http://wiki.openstreetmap.org/wiki/Tag:waterway%3Dwadi and in JOSM) so probably adding rules for it (outside of validator) is not much gain. Or what is the policy in these situations?

comment:7 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: closedreopened

Yes, wadi has a validator warning and no line style. It should therefore not have direction arrows.

comment:8 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

In 9552/josm:

fix #10290 - remove wadi direction arrows; see #12404 - improve fence_type=chain validator warning message

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.