inconsistency rendering direction arrows for waterways

[skyper]

There is at least an inconsistency in rendering direction arrows for waterway=*:

• while canal is rendered with arrows (upper)
• ditch is rendered without arrows (lower)

Please turn it around and do not render arrows for canals as they may have been tagged with oneway=*, too.

Recently there was a dicussion proposing a new tag flow_direction=forward/backward/both/none for man_mad=pipeline and waterway=* as oneway=* is an access condition.

This somehow reminds my about the discussion about rendering incline=*.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-07-21 01:35:49
Last Changed Author: Don-vip
Revision: 7321
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-07-21 01:51:53 +0200 (Mon, 21 Jul 2014)
Last Changed Rev: 7321

Identification: JOSM/1.5 (7321 en) Linux Debian GNU/Linux 7.6 (wheezy)
Memory Usage: 517 MB / 882 MB (260 MB allocated, but free)
Java version: 1.7.0_55, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u55-2.4.7-1~deb7u1
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (30519)
Plugin: conflation (0.1.7)
Plugin: imagery-xml-bounds (30495)
Plugin: jts (30416)
Plugin: mirrored_download (30495)
Plugin: notes (v0.9.2)
Plugin: photoadjust (30428)
Plugin: reverter (30521)
Plugin: terracer (30416)
Plugin: todo (29154)
Plugin: undelete (30416)
Plugin: utilsplugin2 (30460)
Plugin: wikipedia (30449)

[skyper]

screenshot

[skyper]

Forgot:

• wadi usually have a flow direction and it would be consistent to render arrows

[skyper]

This is inconsistent compared to validator, which warns about changing direction of any waterway=*.

[simon04]

In 9538/josm:

see #10290 - Consider waterway=canal as not directional, waterway=ditch|wadi as directional

[simon04]

In 9539/josm:

fix #10290 - Improve ReverseWayNoTagCorrector

It evaluates its own directional tags together with those defined at
OsmPrimitive#directionKeys minus the ones that can be corrected using
ReverseWayTagCorrector.

[aceman]

I think wadi was obsoleted (on wiki ​http://wiki.openstreetmap.org/wiki/Tag:waterway%3Dwadi and in JOSM) so probably adding rules for it (outside of validator) is not much gain. Or what is the policy in these situations?

[Klumbumbus]

Yes, wadi has a validator warning and no line style. It should therefore not have direction arrows.

[Klumbumbus]

In 9552/josm:

fix #10290 - remove wadi direction arrows; see #12404 - improve fence_type=chain validator warning message