Modify

Opened 5 years ago

Closed 5 years ago

#10240 closed defect (fixed)

"IllegalArgumentException: newMinuteStart is not a valid minute" on time editing

Reported by: Anrijs <ajargans@…> Owned by: boman
Priority: normal Milestone:
Component: Plugin openinghourseditor Version:
Keywords: Cc:

Description (last modified by Don-vip)

If You try to edit existing time and pull opening hours line over closing hours line and then outside of editing canvas (top to bottom), plugin raises unexpected exception. Same thing when You do it bottom-top.

Revision: 7291
Repository Root: http://josm.openstreetmap.de/svn
Last Changed Author: Don-vip
Last Changed Date: 2014-07-05 18:38:07 +0200 (Sat, 05 Jul 2014)
Build-Date: 2014-07-06 01:36:19
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 7291

Identification: JOSM/1.5 (7291 en) Windows 8.1 64-Bit
Memory Usage: 94 MB / 1813 MB (19 MB allocated, but free)
Java version: 1.8.0_05, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Djava.security.policy=file:C:\Program Files\Java\jre8\lib\security\javaws.policy, -DtrustProxy=true, -Xverify:remote, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Users\Vincent\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\31\583aa85f-1d873385, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Xbootclasspath/a:C:\Program Files\Java\jre8\lib\javaws.jar;C:\Program Files\Java\jre8\lib\deploy.jar;C:\Program Files\Java\jre8\lib\plugin.jar, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=61868, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm-latest.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=-Djava.util.Arrays.useLegacyMergeSort=true -Djnlp.application.href=https://josm.openstreetmap.de/download/josm-latest.jnlp]
Dataset consistency test: No problems found

Plugin: DirectDownload (30416)
Plugin: OpeningHoursEditor (30416)
Plugin: geotools (30416)
Plugin: jts (30416)
Plugin: opendata (30508)
Plugin: pbf (30495)
Plugin: tageditor (30488)
Plugin: utilsplugin2 (30460)

java.lang.IllegalArgumentException: newMinuteStart is not a valid minute (0-1441). Given value is 1455
	at org.openstreetmap.josm.plugins.ohe.OpeningTimeUtils.ensureValidMinute(OpeningTimeUtils.java:281)
	at org.openstreetmap.josm.plugins.ohe.gui.TimeRect.updateTimeInterval(TimeRect.java:117)
	at org.openstreetmap.josm.plugins.ohe.gui.TimeRect.mouseDragged(TimeRect.java:298)
	at java.awt.Component.processMouseMotionEvent(Unknown Source)
	at javax.swing.JComponent.processMouseMotionEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$400(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.WaitDispatchSupport$2.run(Unknown Source)
	at java.awt.WaitDispatchSupport$4.run(Unknown Source)
	at java.awt.WaitDispatchSupport$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.awt.WaitDispatchSupport.enter(Unknown Source)
	at java.awt.Dialog.show(Unknown Source)
	at java.awt.Component.show(Unknown Source)
	at java.awt.Component.setVisible(Unknown Source)
	at java.awt.Window.setVisible(Unknown Source)
	at java.awt.Dialog.setVisible(Unknown Source)
	at org.openstreetmap.josm.plugins.ohe.OhePlugin$OheMenuAction.actionPerformed(OhePlugin.java:301)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.AbstractButton.doClick(Unknown Source)
	at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
	at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
<...>
	at java.awt.EventDispatchThread.run(Unknown Source)

Attachments (1)

openinghours_ticket.mp4 (374.3 KB) - added by Anrijs <ajargans@…> 5 years ago.
Video showing issue

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by Anrijs <ajargans@…>

Attachment: openinghours_ticket.mp4 added

Video showing issue

comment:1 Changed 5 years ago by Don-vip

Description: modified (diff)

comment:2 Changed 5 years ago by Don-vip

Summary: Error on time editing"IllegalArgumentException: newMinuteStart is not a valid minute" on time editing

comment:3 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

Fixed in [o30519:30520].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain boman.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.