Return key in tag editor currently doesn't work on Mac OSX with Java 8

[Lesath]

In prior versions the return key could be used to enter values in tag editor. Currently I have to use the mouse to click "Ok" to confirm the values.

Steps to reproduce:

1) Click a node or a way (doesn't matter which one)
2) Click "Add" from "Tags"
3) Enter value in the "Please select a key"
4) Press Tab (to change to the second field)
5) Enter value for the second field
6) Try enter return to confirm the value and close the tag editor

Maybe other editors could have the same problem - I didn't check that.

Revision: 7121
Is-Local-Build: true
Build-Date: 2014-05-14 09:21:25

Identification: JOSM/1.5 (7121 SVN en) Mac OS X 10.9.2
Memory Usage: 171 MB / 455 MB (96 MB allocated, but free)
Java version: 1.8.0, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Djava.library.path=/Applications/JOSM_custom.app/Contents/MacOS, -DLibraryDirectory=/Users/wsobotta/Library, -DDocumentsDirectory=/Users/wsobotta/Documents, -DApplicationSupportDirectory=/Users/wsobotta/Library/Application Support, -DCachesDirectory=/Users/wsobotta/Library/Caches, -DSandboxEnabled=false, -Xmx512m, -Dapple.laf.useScreenMenuBar=true, -Dcom.apple.macos.use-file-dialog-packages=true, -Dcom.apple.macos.useScreenMenuBar=true, -Dcom.apple.mrj.application.apple.menu.about.name=JOSM, -Dcom.apple.smallTabs=true]
Dataset consistency test: No problems found

Plugin: FastDraw (30416)
Plugin: OpeningHoursEditor (30416)
Plugin: download_along (30416)
Plugin: imagery_offset_db (30416)
Plugin: turnlanes (30416)
Plugin: turnrestrictions (30416)

[Don-vip]

Works for me with

Revision: 7122
Is-Local-Build: true
Build-Date: 2014-05-14 10:19:45

Identification: JOSM/1.5 (7122 SVN en) Windows 8.1 64-Bit
Memory Usage: 60 MB / 2731 MB (15 MB allocated, but free)
Java version: 1.8.0_05, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Xmx3G, -Dfile.encoding=UTF-8]

@Lesath, can you please:

• update your Java version to 8u5 and tell us if the bug's still here
• if yes, attach a screenshot of the add tag dialog when you're typing the second key, to see where the focus is.

@cquest, Stereo: do you reproduce this bug with Java 7u55?

Thanks.

[Stereo]

Hi everyone,

I can't reproduce this bug with build 7000 with Java 7u55 on Mac OS X.

@Lesath can you back up your ~/.josm directory and try with a fresh one? What about a fresh user account? Are you running any software that remaps keyboard keys?

[Lesath]

This seems to be related to the Mac OS X Theme here on Mac - I've will test JDK 8u5 shortly - but it seems to be a bug in the Mac OS X theme - in Metal theme is the bug not reproducable.

BTW: I'm using no input remappers or something other things. The moving of the ~/.josm did not bring up the solution - as soon as I switch to "Mac OS X" theme the bug is there.

[Lesath]

Showing focus after the reproducable steps

[Lesath]

Ok - the Bug still persists with the Mac OS X Theme with JDK 8u5. I've got currently no time to debug it by myself. I will try it today evening.

[Stereo]

I use the Mac OS X theme too. Who's crazy enough to use the Metal theme? :) My focus looks just like yours. The only difference I can see is that your interface is in German, and I really can't see how that could interfere with the focus.

Maybe try by creating a fresh Mac OS X user account?

[Don-vip]

Could be this Java bug: ​https://bugs.openjdk.java.net/browse/JDK-8031485
Seems only to affect Java 8. Fix targeted to ​8u20, to be released in August.

[Don-vip]

Yes, that's it. It is described in ​JDK8 release notes:

Area: Client Libs / java.swing

Synopsis
On Mac OS X, the ComboBox control consumes the Esc and Enter keys. When the ComboBox in a dialog box has focus, the keyboard cannot be used to close the dialog box.

Bug
​8031485

Two solutions:

• wait for JDK 8u20 in August
• downgrade to Java 7u55

[Lesath]

Yes - this it is. Thanks for the pointing to the java-bug! (Also nice to know for me as a programmer ;-) )

[Don-vip]

Replying to Lesath:

Also nice to know for me as a programmer ;-)

Wait... you're a Java developer on Mac OSX? :) We'd love some help on Mac-specific tickets :)

[Lesath]

Replying to Don-vip:

Replying to Lesath:

Also nice to know for me as a programmer ;-)

Wait... you're a Java developer on Mac OSX? :) We'd love some help on Mac-specific tickets :)

Ahh - damn it - I knew it - I've should never revealed that I'm a programmer - but I will look into the today evening - since this ticket is resolved ;-)

[Stereo]

Fantastic, I'll add all the Mac OS X issues that have been bugging me for a while to the bug tracker :)

[Don-vip]

​Java 8u20 has been released and contains fix for this bug, you should update to this version.

[Stereo]

The bug is actually still there for me in Java Version 1.8.0_20. However, pressing 'tab' after entering the tag value switches focus to the button. The change of focus lets me use 'enter' to close the dialog.

[Don-vip]

Ticket #10459 has been marked as a duplicate of this ticket.

[Don-vip]

Indeed I can finally reproduce the problem with 8u20 as well.

[Don-vip]

Looks like the ​fix is incomplete and only corrected the handling of Escape, not Enter.

[Don-vip]

I have sent another bug report to Oracle. If it gets accepted it will be available ​here.

[Don-vip]

The bug has been confirmed, we must wait for its correction by Oracle: ​javabug:8058193. I hope it will be fixed in next update (8u40).

[Don-vip]

Just fixed in 8u40: ​javabug:8065376

[Stereo]

I can confirm that this problem no longer exists in 8u31. Thank you!

[Don-vip]

Ticket #11132 has been marked as a duplicate of this ticket.

[Don-vip]

Ticket #11235 has been marked as a duplicate of this ticket.

[flaimo]

I updated to Java 8 Update 40 on Mac OS 10.10. Problem still exists.

[Don-vip]

It shouldn't. Can you please attach your status report and a screenshot?

[Lesath]

Seems to be a problem with JDK 8.0 u40 - will be fixed with JDK 8.0u45 according to ​javabug:8067583

[Don-vip]

Nop, that's just a backport of the same bug because 8u45 and 8u40 have been developed at the same time. 8u45 probably won't change anything. Do you reproduce the problem, Lesath?

[Lesath]

Yes - the problem is still the same - no changes for me here ;-)

On the other hand - I've tried yesterday the preview from JDK 9 - there was the bug gone - thus not reproducible. The same is still for JDK 7... So it seems to be a bug in JDK 8.

[Don-vip]

Ticket #11352 has been marked as a duplicate of this ticket.

[Mashin]

Java version: 1.8.0_51
Problem still persists, however:

• Ctrl + Enter adds a new tag
• Enter works when editing already existing tag.

[Stereo]

I can't reproduce this in 1.8.0_101. Hitting the Return key enters the new tag.

Can the mac user CC'd on this bug please see if they can still reproduce it?

[flaimo]

Works for me now too. Just took Oracle 2 years to fix it :-/