Opened 11 years ago
Closed 10 years ago
#10018 closed defect (fixed)
Avoid broken relations after concatenating ways
Reported by: | rayquaza | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 15.10 |
Component: | Core | Version: | |
Keywords: | Cc: |
Description
I found an easy way to break some route-relations:
- Create four ways, which describe a closed ring. Name them "A", "B", "C" and "D"
- Create a route relation which contains those ways in the following order: A, B, C, D, A, B, C, D (so every way is used twice)
- Concatenate the ways B and C
The relation will now contain the ways A, BC, D, A, D.
The expected result would be A, BC, D, A, BC, D.
Attachments (1)
Change History (15)
comment:1 by , 11 years ago
Milestone: | → 14.05 |
---|---|
Type: | enhancement → defect |
comment:2 by , 11 years ago
There are some strange effects with duplicates as members. JOSM even does not make any differences if you have two different roles (e.g. connecting ways/merging).
comment:3 by , 11 years ago
@Don-vip: tested (r7000). I just tried with latest, so here's it's statusreport (I knew I forgot something…):
Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2014-05-14 01:35:50 Last Changed Author: Don-vip Revision: 7120 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2014-05-14 02:16:44 +0200 (Wed, 14 May 2014) Last Changed Rev: 7120 Identification: JOSM/1.5 (7120 de) Windows XP 32-Bit Memory Usage: 130 MB / 247 MB (75 MB allocated, but free) Java version: 1.7.0_55, Oracle Corporation, Java HotSpot(TM) Client VM Dataset consistency test: No problems found Plugin: Create_grid_of_ways (30416) Plugin: InfoMode (30416) Plugin: OpeningHoursEditor (30416) Plugin: PicLayer (30436) Plugin: alignways (30416) Plugin: buildings_tools (30416) Plugin: conflation (0.1.6) Plugin: continuosDownload (28565) Plugin: contourmerge (1010) Plugin: editgpx (30416) Plugin: geochat (30416) Plugin: imageryadjust (30416) Plugin: importvec (30416) Plugin: jts (30416) Plugin: measurement (30416) Plugin: mirrored_download (30436) Plugin: notes (v0.9.2) Plugin: openstreetbugs (30436) Plugin: osmarender (30416) Plugin: pbf (30416) Plugin: poly (30416) Plugin: print (30416) Plugin: proj4j (30417) Plugin: reverter (30436) Plugin: tagging-preset-tester (30416) Plugin: terracer (30416) Plugin: todo (29154) Plugin: turnrestrictions (30416) Plugin: undelete (30416) Plugin: utilsplugin2 (30419)
follow-up: 8 comment:4 by , 11 years ago
Example: attachment:combine.osm, combine the two highway
s and inspect the relation.
org.openstreetmap.josm.gui.conflict.tags.CombinePrimitiveResolverDialog#prepareDefaultRelationDecisions
needs to be fixed …
comment:6 by , 11 years ago
The number of occurrences should be fixed now, but still, the roles might get confused – see example from comment:4.
by , 11 years ago
Attachment: | combine.osm added |
---|
comment:8 by , 11 years ago
Replying to simon04:
org.openstreetmap.josm.gui.conflict.tags.CombinePrimitiveResolverDialog#prepareDefaultRelationDecisions
needs to be fixed
Do you think it's easy? So we can wait for it before releasing, or do we fix this in next version?
comment:9 by , 11 years ago
No, let's keep that for a subsequent release. I guess this bug has been around for a long time, so +/− one month shouldn't make a big difference …
comment:11 by , 11 years ago
Milestone: | 14.06 → 14.07 |
---|
Move all tickets for which no work has been done yet to next milestone
comment:12 by , 11 years ago
Milestone: | 14.07 |
---|
comment:13 by , 10 years ago
Milestone: | → 15.10 |
---|
Indeed. This is clearly a bug :) Just to be sure, you have seen this with latest JOSM? This one's easy to test, but always attaching a status report is a good habit ;)