[Patch] Add support for canvas{fill-color}, deprecate canvas{background-color}

[simon04]

According to ​https://wiki.osm.org/wiki/MapCSS/0.2#Canvas_properties, the "official" tag for setting the background color using MapCSS is

canvas{
  fill-color: #abcdef;
}

instead of

canvas{
  background-color: #abcdef;
}

Therefore, I suggest to support the standard and deprecate the current implementation.

src/org/openstreetmap/josm/gui/mappaint/mapcss/MapCSSStyleSource.java

@@ -202 +202 @@
 
     private void loadCanvas() {
         Cascade c = constructSpecial("canvas");
-        backgroundColorOverride = c.get("background-color", null, Color.class);
+        backgroundColorOverride = c.get("fill-color", null, Color.class);
+        if (backgroundColorOverride == null) {
+            backgroundColorOverride = c.get("background-color", null, Color.class);
+            if (backgroundColorOverride != null) {
+                Main.warn("Detected deprecated canvas{background-color} which will be removed shortly.");
+            }
+        }
     }
 
     private Cascade constructSpecial(String type) {

[bastiK]

Good idea!

[simon04]

In 7110/josm:

fix #10014 - MapCSS: Add support for canvas{fill-color}, deprecate canvas{background-color}

[Don-vip]

In 7127/josm:

see #10014 - use fill-color instead of background-color in P2 mapcss style

[anonymous]

The background colour of power=pole icons (in the Potlatch2 style) has disappeared! :-(