#11945 closed defect (fixed)
JOSM merges segments with same tags but different relations without warning
Reported by: | planemad | Owned by: | simon04 |
---|---|---|---|
Priority: | normal | Milestone: | 15.10 |
Component: | Core | Version: | |
Keywords: | template_report | Cc: |
Description (last modified by )
What steps will reproduce the problem?
- Select ways with the same tags but part of different relations https://www.openstreetmap.org/way/262004258
- Combine them (c)
What is the expected result?
A warning dialog box appears that shows what new relations are going to be added to the merged ways, similiar to the dialog when combining objects with different tags
What happens instead?
Merging of all relations happens with no warning. This can result in breaking existing relations if the user was not paying attention to the relation tags of the selection.
Merging without warning should only happen if the members are part of the same relation.
Please provide any additional information below. Attach a screenshot if possible.
Merging relations without warning when object tags are the same
When the object tags are modified and an attempt is made to merge, the warning is displayed
Revision: 8800 Repository Root: http://josm.openstreetmap.de/svn Relative URL: ^/trunk Last Changed Author: simon04 Last Changed Date: 2015-09-27 22:11:06 +0200 (Sun, 27 Sep 2015) Build-Date: 2015-09-28 01:32:03 URL: http://josm.openstreetmap.de/svn/trunk Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last Changed Rev: 8800 Identification: JOSM/1.5 (8800 en) Mac OS X 10.10.3 Memory Usage: 967 MB / 1820 MB (585 MB allocated, but free) Java version: 1.8.0_60, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM VM arguments: [-Djava.security.policy=file:/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=/Users/arun/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-1b8e9edd, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Dmacosx.jnlpx.dock.name=JOSM, -Dmacosx.jnlpx.dock.icon=/Users/arun/Library/Application Support/Oracle/Java/Deployment/cache/6.0/16/47ee53d0-70f4e903.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp , -Djnlpx.jvm="/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java", -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAC1Eam5scC5hcHBsaWNhdGlvbi5ocmVmPWh0dHBzOi8vam9zbS5vcGVuc3RyZWV0bWFwLmRlL2Rvd25sb2FkL2pvc20uam5scCAA] Dataset consistency test: No problems found Plugins: - CommandLine (31241) - Create_grid_of_ways (31241) - FastDraw (31265) - Mapillary (31550) - OSMRecPlugin (31557) - PicLayer (31241) - ShapeTools (1000) - buildings_tools (31558) - commons-imaging (31241) - dataimport (31241) - ext_tools (31241) - geochat (31241) - geotools (31126) - graphview (31241) - jts (31126) - lakewalker (31241) - log4j (31231) - opendata (31241) - public_transport (31241) - rasterfilters (31509) - reltoolbox (31241) - reverter (31241) - scripting (30710) - terracer (31241) - turnlanes (31241) - undelete (31241) - utilsplugin2 (31463) - wikipedia (31241) - wms-turbo-challenge2 (31308) Last errors/warnings: - W: PluginException: Invalid jar file '/Users/arun/Library/JOSM/plugins/imagery_offset_db.jar.new' - W: Failed to scan file 'imagery_offset_db.jar.new' for plugin information. Skipping. - W: Failed to install plugin '/Users/arun/Library/JOSM/plugins/imagery_offset_db.jar' from temporary download file '/Users/arun/Library/JOSM/plugins/imagery_offset_db.jar.new'. error in opening zip file
Attachments (1)
Change History (8)
by , 10 years ago
Attachment: | 2015-10-08-110418_701x292_scrot.png added |
---|
follow-up: 2 comment:1 by , 10 years ago
Resolution: | → worksforme |
---|---|
Status: | new → closed |
follow-up: 4 comment:2 by , 10 years ago
Replying to simon04:
Combining
way 262004258,way 262004245,way 262004263
displays the dialog "You are about to combine 3 objects, which are part of 4 relations"
I'm still not seeing the dialog. Any extra details I could provide to figure out why the warning does not show?
comment:3 by , 10 years ago
Description: | modified (diff) |
---|---|
Resolution: | worksforme |
Status: | closed → reopened |
Summary: | JOSM merges segments with different relations without warning → JOSM merges segments with same tags but different relations without warning |
comment:4 by , 10 years ago
Have found the issue:
- If object tags are different and relations are different > warning is displayed
- If object tags are same and relations are different > no warning is displayed
Updated ticket with these details
comment:5 by , 10 years ago
Milestone: | → 15.10 |
---|---|
Owner: | changed from | to
Status: | reopened → new |
Combining
way 262004258,way 262004245,way 262004263
displays the dialog "You are about to combine 3 objects, which are part of 4 relations"