Changeset 14977 in josm for trunk/test/unit/org/openstreetmap/josm

Timestamp:

2019-04-09T01:32:56+02:00 (5 years ago)

Author:

Don-vip

Message:

ensures consistency of upload comment:

• fix #11168 - ctrl-z/undo could reset unwanted old changeset comment
• fix #13474 - selecting "new changeset" after having entered a changeset comment did reset it to the previous value
• fix #17452 - ctrl-enter while typing a changeset comment did upload with the previous value
• fix behaviour of upload.comment.max-age: values were reset after 5 months instead of intended 4 hours because seconds were compared to milliseconds
• avoid creation of unneeded undo/redo internal classes for non-editable text fields
• ensures consistency of upload dialog if upload.comment properties are modified manually from advanced preferences
• add a source attribute to preference events to know which class modified the preference entry
• refactor reflection utils

Location:

trunk/test/unit/org/openstreetmap/josm

Files:

• TestUtils.java (modified) (2 diffs)
• actions/CreateCircleActionTest.java (modified) (2 diffs)
• actions/mapmode/SelectActionTest.java (modified) (2 diffs)
• gui/TableCellRendererTest.java (modified) (2 diffs)
• gui/io/UploadDialogTest.java (modified) (4 diffs)

trunk/test/unit/org/openstreetmap/josm/TestUtils.java

@@ -54 +54 @@
 import org.openstreetmap.josm.testutils.mockers.WindowMocker;
 import org.openstreetmap.josm.tools.JosmRuntimeException;
+import org.openstreetmap.josm.tools.ReflectionUtils;
 import org.openstreetmap.josm.tools.Utils;
 import org.openstreetmap.josm.tools.WikiReader;
@@ -413 +414 @@
             Method values = enumClass.getMethod("values");
             Method valueOf = enumClass.getMethod("valueOf", String.class);
-            Utils.setObjectsAccessible(values, valueOf);
+            ReflectionUtils.setObjectsAccessible(values, valueOf);
             for (Object o : (Object[]) values.invoke(null)) {
                 assertEquals(o, valueOf.invoke(null, ((Enum<?>) o).name()));

trunk/test/unit/org/openstreetmap/josm/actions/CreateCircleActionTest.java

@@ -21 +21 @@
 import org.openstreetmap.josm.tools.GeoPropertyIndex;
 import org.openstreetmap.josm.tools.Geometry;
+import org.openstreetmap.josm.tools.ReflectionUtils;
 import org.openstreetmap.josm.tools.RightAndLefthandTraffic;
-import org.openstreetmap.josm.tools.Utils;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
@@ -118 +118 @@
         // Mock left/right hand traffic database
         Field rlCache = RightAndLefthandTraffic.class.getDeclaredField("rlCache");
-        Utils.setObjectsAccessible(rlCache);
+        ReflectionUtils.setObjectsAccessible(rlCache);
         Object origRlCache = rlCache.get(null);
         rlCache.set(null, new GeoPropertyIndex<>(new ConstantTrafficHand(true), 24));

trunk/test/unit/org/openstreetmap/josm/actions/mapmode/SelectActionTest.java

@@ -27 +27 @@
 import org.openstreetmap.josm.spi.preferences.Config;
 import org.openstreetmap.josm.testutils.JOSMTestRules;
-import org.openstreetmap.josm.tools.Utils;
+import org.openstreetmap.josm.tools.ReflectionUtils;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
@@ -42 +42 @@
             super(mapFrame);
             Field mv = SelectAction.class.getDeclaredField("mv");
-            Utils.setObjectsAccessible(mv);
+            ReflectionUtils.setObjectsAccessible(mv);
             mv.set(this, new MapViewMock(new MainLayerManager()));
         }

trunk/test/unit/org/openstreetmap/josm/gui/TableCellRendererTest.java

@@ -20 +20 @@
 import org.openstreetmap.josm.testutils.JOSMTestRules;
 import org.openstreetmap.josm.tools.Logging;
-import org.openstreetmap.josm.tools.Utils;
+import org.openstreetmap.josm.tools.ReflectionUtils;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
@@ -99 +99 @@
             c = klass.getDeclaredConstructor();
         }
-        Utils.setObjectsAccessible(c);
+        ReflectionUtils.setObjectsAccessible(c);
         if (needOuterClass) {
             return c.newInstance(createInstance(klass.getDeclaringClass()));

trunk/test/unit/org/openstreetmap/josm/gui/io/UploadDialogTest.java

@@ -4 +4 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 
 import java.awt.GraphicsEnvironment;
+import java.util.Arrays;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
+import java.util.function.Supplier;
+
 import javax.swing.JButton;
 import javax.swing.JOptionPane;
@@ -15 +19 @@
 import org.junit.Rule;
 import org.junit.Test;
+import org.openstreetmap.josm.TestUtils;
 import org.openstreetmap.josm.gui.ExtendedDialog;
-import org.openstreetmap.josm.TestUtils;
 import org.openstreetmap.josm.io.UploadStrategySpecification;
+import org.openstreetmap.josm.spi.preferences.Config;
 import org.openstreetmap.josm.testutils.JOSMTestRules;
 import org.openstreetmap.josm.testutils.mockers.ExtendedDialogMocker;
 import org.openstreetmap.josm.testutils.mockers.WindowMocker;
 
+import com.google.common.collect.ImmutableMap;
+
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import mockit.Invocation;
 import mockit.Mock;
-
-import com.google.common.collect.ImmutableMap;
-
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 /**
@@ -96 +100 @@
         public Map<String, String> getTags(boolean keepEmpty) {
             return new ConcurrentHashMap<>();
+        }
+
+        @Override
+        public void forceUpdateActiveField() {
+            // Do nothing
         }
     }
@@ -214 +223 @@
         assertTrue(UploadDialog.UploadAction.isUploadCommentTooShort("\u0860"));
     }
+
+    private static void doTestGetLastChangesetTagFromHistory(String historyKey, Supplier<String> methodToTest, String def) {
+        Config.getPref().putList(historyKey, null);
+        Config.getPref().putInt(BasicUploadSettingsPanel.HISTORY_LAST_USED_KEY, 0);
+        Config.getPref().putInt(BasicUploadSettingsPanel.HISTORY_MAX_AGE_KEY, 30);
+        assertNull(methodToTest.get());          // age NOK (history empty)
+        Config.getPref().putList(historyKey, Arrays.asList("foo"));
+        assertNull(methodToTest.get());          // age NOK (history not empty)
+        Config.getPref().putLong(BasicUploadSettingsPanel.HISTORY_LAST_USED_KEY, System.currentTimeMillis() / 1000);
+        assertEquals("foo", methodToTest.get()); // age OK, history not empty
+        Config.getPref().putList(historyKey, null);
+        assertEquals(def, methodToTest.get());   // age OK, history empty
+    }
+
+    /**
+     * Test of {@link UploadDialog#getLastChangesetCommentFromHistory} method.
+     */
+    @Test
+    public void testGetLastChangesetCommentFromHistory() {
+        doTestGetLastChangesetTagFromHistory(
+                BasicUploadSettingsPanel.HISTORY_KEY,
+                UploadDialog::getLastChangesetCommentFromHistory,
+                null);
+    }
+
+    /**
+     * Test of {@link UploadDialog#getLastChangesetSourceFromHistory} method.
+     */
+    @Test
+    public void testGetLastChangesetSourceFromHistory() {
+        doTestGetLastChangesetTagFromHistory(
+                BasicUploadSettingsPanel.SOURCE_HISTORY_KEY,
+                UploadDialog::getLastChangesetSourceFromHistory,
+                BasicUploadSettingsPanel.getDefaultSources().get(0));
+    }
 }