Changeset 14977 in josm for trunk/src/org/openstreetmap/josm/gui/dialogs/changeset

Timestamp:

2019-04-09T01:32:56+02:00 (5 years ago)

Author:

Don-vip

Message:

ensures consistency of upload comment:

• fix #11168 - ctrl-z/undo could reset unwanted old changeset comment
• fix #13474 - selecting "new changeset" after having entered a changeset comment did reset it to the previous value
• fix #17452 - ctrl-enter while typing a changeset comment did upload with the previous value
• fix behaviour of upload.comment.max-age: values were reset after 5 months instead of intended 4 hours because seconds were compared to milliseconds
• avoid creation of unneeded undo/redo internal classes for non-editable text fields
• ensures consistency of upload dialog if upload.comment properties are modified manually from advanced preferences
• add a source attribute to preference events to know which class modified the preference entry
• refactor reflection utils

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetDetailPanel.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetDetailPanel.java

@@ -57 +57 @@
 
     // CHECKSTYLE.OFF: SingleSpaceSeparator
-    private final JosmTextField tfID        = new JosmTextField(10);
+    private final JosmTextField tfID        = new JosmTextField(null, null, 10, false);
     private final JosmTextArea  taComment   = new JosmTextArea(5, 40);
-    private final JosmTextField tfOpen      = new JosmTextField(10);
-    private final JosmTextField tfUser      = new JosmTextField("");
-    private final JosmTextField tfCreatedOn = new JosmTextField(20);
-    private final JosmTextField tfClosedOn  = new JosmTextField(20);
+    private final JosmTextField tfOpen      = new JosmTextField(null, null, 10, false);
+    private final JosmTextField tfUser      = new JosmTextField(null, "", 0);
+    private final JosmTextField tfCreatedOn = new JosmTextField(null, null, 20, false);
+    private final JosmTextField tfClosedOn  = new JosmTextField(null, null, 20, false);
 
     private final OpenChangesetPopupMenuAction   actOpenChangesetPopupMenu   = new OpenChangesetPopupMenuAction();