Opened 12 years ago
Closed 10 years ago
#7697 closed enhancement (othersoftware)
option to keep references in place
Reported by: | skyper | Owned by: | joshdoe |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Plugin conflation | Version: | |
Keywords: | keep subjects github | Cc: |
Description (last modified by )
When conflating housenumber nodes to closed ways, I often use the nodes to mark the main entrance. E.g. In some occasions it might be useful only to move all the tags/memberships but not move/merge the references but just keep them in place.
A little check-box would be nice.
Thanks
Attachments (0)
Change History (5)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
Description: | modified (diff) |
---|---|
Summary: | option to keep subjects in place → option to keep references in place |
Sorry mixed up references/subjects but you got it right.
Wow, did not think that I did open up a big pot. I did not think about different layers and did not try it yet but nice if it is working.
- Not touching the other layer is perfect.
- I am not sure if you really need the distinction per match as I think it is much faster to do several conflation actions than to check match after match.
- My request was to move tag/membership from reference to subject but keeping the reference object in place without tag/membership.
- To only copy tag/membership in the same layer leads to duplicate data which does not seem to be right.
- Only replace geometry but removing/deleting all tags/memberships is not needed as it is not hard to manually delete them first. It also leads to some other direction as for me the most difficult action is the moving of tag/membership. Only useful with different layers.
I am still in favour of setting this option either in the reference/subject dialogue or in the toggle dialogue.
- Replace geometry (removes reference if it's in the same layer as the subject)
- Keep reference object (only move tag/membership)
- Keep copied tags from reference (only if 2 is checked and different layers)
By default 1 will be checked (3 is N/A) if reference and subject are in the same layer otherwise 1 to 3 will be checked.
comment:3 by , 11 years ago
I have a similar (the same?) issue. Basically, sometimes the geometry of the reference is best, and sometimes the geometry of the subject is best. In the first case, normal conflation works fine (i.e., replace geometry and conflate tags). In the second case, I would only want to conflate the tags, and leave the subject geometry in place.
For me, adding another button (‘Conflate tags’) would be the best solution. For the third use case of only wanting to replace the geometry, a third button for this could perhaps also be added. So, basically, three buttons:
Replace geometry
Conflate tags
Conflate both
(I’m sure there are better names that can be used for the buttons.)
comment:4 by , 11 years ago
Keywords: | github added |
---|
comment:5 by , 10 years ago
Resolution: | → othersoftware |
---|---|
Status: | new → closed |
Closing tickets for external Github-hosted plugins as "othersoftware". Bug report is done on Github, see https://github.com/joshdoe/josm-conflation-plugin/issues/10.
Hmm, so copy tags/relation memberships to the subject and remove them from the reference, but not move the subject? Would it make sense to copy tags/memberships but NOT remove them from the reference? One assumption I have is that if the reference is from another layer, I'll never touch that layer at all (let me know if you think I shouldn't assume this).
Ideally making this choice should be on a per match basis, meaning that it shouldn't be a button on the toggle dialog but rather it should appear on the tag/membership conflict resolution dialog, which means changing that dialog (currently I use it as from JOSM core).
The actions that one might want to do seem to be:
Anything else I'm missing? This maybe can be distilled down to the following, each of which can be represented by a checkbox:
By default 1, 2 and 4 will be checked (3 is N/A). If 1 is checked, 4 will be checked (so no duplicate nodes/geometry). If 2 is checked the tag/membership tables will be disabled. For 3 to be checked, 2 must be checked. If 4 is checked, 3 will be disabled.
Seems complicated, so if there's a smarter way please let me know.