Modify

Opened 2 years ago

Closed 2 years ago

#6368 closed enhancement (fixed)

[PATCH] Enter key pressing hanlder for text fields in Credentials dialog

Reported by: Kachkaev Owned by: team
Priority: normal Component: Core
Version: Keywords: usability
Cc:

Description

People got used to submit credentials forms by pressing enter after they type their name and password.
JOSM does not have this feature at the moment, so every time you login, you have to tab to OK button or press it with mouse.

I’ve made a patch to fix this issue. So now when you press enter after filling username and password, fields, you submit the form. If you just typed your username and pressed enter, password field is getting focused (and vice versa). If current input field is empty (or is just a sequence of spaces), nothing happens.

Basically, it’s a “scratching my own itch” patch as I am getting a bit frustrated every time I mechanically press enter and get noting.

Attachments (3)

CredentialDialog Enter pressing handler.patch (4.9 KB) - added by Kachkaev 2 years ago.
CredentialDialog Enter pressing handler.2.patch (4.9 KB) - added by Kachkaev 2 years ago.
small formatting fixes
CredentialDialog Enter pressing handler.3.patch (5.0 KB) - added by Kachkaev 2 years ago.
Forgot trim() on line 308 :)

Download all attachments as: .zip

Change History (5)

Changed 2 years ago by Kachkaev

comment:1 Changed 2 years ago by anonymous

  • Keywords usability added
  • Type changed from defect to enhancement

Changed 2 years ago by Kachkaev

small formatting fixes

Changed 2 years ago by Kachkaev

Forgot trim() on line 308 :)

comment:2 Changed 2 years ago by stoecker

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r4110.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.