Modify

Opened 14 years ago

Closed 14 years ago

#6368 closed enhancement (fixed)

[PATCH] Enter key pressing hanlder for text fields in Credentials dialog

Reported by: Alexander Kachkaev <alexander@…> Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: usability Cc:

Description

People got used to submit credentials forms by pressing enter after they type their name and password.
JOSM does not have this feature at the moment, so every time you login, you have to tab to OK button or press it with mouse.

I’ve made a patch to fix this issue. So now when you press enter after filling username and password, fields, you submit the form. If you just typed your username and pressed enter, password field is getting focused (and vice versa). If current input field is empty (or is just a sequence of spaces), nothing happens.

Basically, it’s a “scratching my own itch” patch as I am getting a bit frustrated every time I mechanically press enter and get noting.

Attachments (3)

CredentialDialog Enter pressing handler.patch (4.9 KB ) - added by Alexander Kachkaev <alexander@…> 14 years ago.
CredentialDialog Enter pressing handler.2.patch (4.9 KB ) - added by Alexander Kachkaev <alexander@…> 14 years ago.
small formatting fixes
CredentialDialog Enter pressing handler.3.patch (5.0 KB ) - added by Alexander Kachkaev <alexander@…> 14 years ago.
Forgot trim() on line 308 :)

Download all attachments as: .zip

Change History (5)

by Alexander Kachkaev <alexander@…>, 14 years ago

comment:1 by anonymous, 14 years ago

Keywords: usability added
Type: defectenhancement

by Alexander Kachkaev <alexander@…>, 14 years ago

small formatting fixes

by Alexander Kachkaev <alexander@…>, 14 years ago

Forgot trim() on line 308 :)

comment:2 by stoecker, 14 years ago

Resolution: fixed
Status: newclosed

Fixed in r4110.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.