[PATCH]Select last node of way when undoing Follow Line

[Manchito]

1. Extend a line with Follow Line
2. Undo the last action
3. Try to use Follow Line again
4. Crash

[stoecker]

I think this patch fixes symptoms instead of real cause.

[bastiK]

Undo is a little strange for follow line:

• Press F a few times
• Ctrl-Z --> rubber line vanishes
• Ctrl-Z repeatedly until you reach the first node --> rubber line comes back and is attached to the (still selected) last node

I think it would be best, if undo moved the rubber line back node by node.

[stoecker]

In [4111/josm]:

fix #6367 - patch by Manchito - fix NPE

[stoecker]

@Manchito:
Please no formatting changes in patches.

@bastiK:
That is an normal DrawAction issue, as the last node of a ChangeCommand stays selected. But currently we do not do real selection handling in Undo/Redo. I do not know if it is a good idea to introduce this. It could take a lot of memory and bring little benefits. But maybe we can link the existing SelectionHistory to Undo/Redo, so in case we have a selection history we can use it.

[skyper]

Would be nice if the selected node would change to the last node of the way.

Right now I often only miss a "crossing" by one or two nodes and hit undo. If have to manually select the last node to continue drawing which means changing modes twice.

Thanks

[landwirt@…]

Letting the undo command select the last node is an expected behavior, doing not so is clearly a defect.

[landwirt@…]

patch for undoing Follow Line

[landwirt@…]

With the new patch josm sets the selection to the last node after undoing Follow Line. Feel free to test it.

[stoecker]

This patch looks like it has been overlooked. Anyone tested it?

[skyper]

Any news ?

[skyper]

Another six month have passed.

[skyper]

ping

This is really annoying and the patch is waiting over 21 month for review now.

[simon04]

In 7122/josm:

fix #6367 - Select last node of way when undoing Follow line (patch by Landwirt, updated, modified)