Modify

Opened 2 years ago

Last modified 6 weeks ago

#6367 reopened defect

[PATCH]Select last node of way when undoing Follow Line

Reported by: Manchito Owned by: team
Priority: normal Component: Core
Version: latest Keywords: undo follow line
Cc:

Description (last modified by stoecker)

  1. Extend a line with Follow Line
  2. Undo the last action
  3. Try to use Follow Line again
  4. Crash

Attachments (2)

undo_crash.patch (1.7 KB) - added by Manchito 2 years ago.
JOSM.patch (5.6 KB) - added by landwirt@… 16 months ago.
patch for undoing Follow Line

Download all attachments as: .zip

Change History (12)

Changed 2 years ago by Manchito

comment:1 Changed 2 years ago by stoecker

  • Summary changed from Crash when using Follow Line action after undo to [patch] Crash when using Follow Line action after undo

I think this patch fixes symptoms instead of real cause.

comment:2 Changed 2 years ago by bastiK

Undo is a little strange for follow line:

  • Press F a few times
  • Ctrl-Z --> rubber line vanishes
  • Ctrl-Z repeatedly until you reach the first node --> rubber line comes back and is attached to the (still selected) last node

I think it would be best, if undo moved the rubber line back node by node.

comment:3 Changed 2 years ago by stoecker

  • Resolution set to fixed
  • Status changed from new to closed

In [4111/josm]:

fix #6367 - patch by Manchito - fix NPE

comment:4 Changed 2 years ago by stoecker

@Manchito:
Please no formatting changes in patches.

@bastiK:
That is an normal DrawAction issue, as the last node of a ChangeCommand stays selected. But currently we do not do real selection handling in Undo/Redo. I do not know if it is a good idea to introduce this. It could take a lot of memory and bring little benefits. But maybe we can link the existing SelectionHistory to Undo/Redo, so in case we have a selection history we can use it.

comment:5 Changed 22 months ago by skyper

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Summary changed from [patch] Crash when using Follow Line action after undo to Select last node of way when undoing Follow Line (WAS:Crash when using Follow Line action after undo)
  • Type changed from defect to enhancement

Would be nice if the selected node would change to the last node of the way.

Right now I often only miss a "crossing" by one or two nodes and hit undo. If have to manually select the last node to continue drawing which means changing modes twice.

Thanks

comment:6 Changed 16 months ago by landwirt@…

  • Summary changed from Select last node of way when undoing Follow Line (WAS:Crash when using Follow Line action after undo) to Select last node of way when undoing Follow Line
  • Type changed from enhancement to defect

Letting the undo command select the last node is an expected behavior, doing not so is clearly a defect.

Changed 16 months ago by landwirt@…

patch for undoing Follow Line

comment:7 Changed 16 months ago by landwirt@…

  • Summary changed from Select last node of way when undoing Follow Line to [PATCH]Select last node of way when undoing Follow Line

With the new patch josm sets the selection to the last node after undoing Follow Line. Feel free to test it.

comment:8 Changed 8 months ago by stoecker

  • Description modified (diff)

This patch looks like it has been overlooked. Anyone tested it?

comment:9 Changed 7 months ago by skyper

Any news ?

comment:10 Changed 6 weeks ago by skyper

Another six month have passed.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as reopened .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team. Next status will be 'new'.
Next status will be 'needinfo'.The owner will change to Manchito
as duplicate The resolution will be set to duplicate. Next status will be 'closed'.The specified ticket will be cross-referenced with this ticket
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.