Entered values in Einstein dialog are ignored

[stoecker]

When value in the einstein dialog are entered, they are ignored. Previously these have been ignored only when return has not been pressed. Now they are ignored always when not using the buttons.

[stoecker]

Ticket #2736 has been marked as a duplicate of this ticket.

[subSet]

Suggested change: Table cells not editable directly. There are no listeners on the cells themselves, so we don't want to leave the impression that you can change them directly. Instead Double clicking on a field still brings up the dialog box to edit it's value, as does clicking the edit button. This behavior would be consistent with other programs such as Firefox.

simple one line fix:

Code Change:
$ svn diff
Index: src/org/openstreetmap/josm/gui/preferences/AdvancedPreference.java
===================================================================
--- src/org/openstreetmap/josm/gui/preferences/AdvancedPreference.java (revision 1685)
+++ src/org/openstreetmap/josm/gui/preferences/AdvancedPreference.java (working copy)
@@ -68,7 +68,7 @@

model = new DefaultTableModel(new String[]{tr("Key"), tr("Value")},0) {

@Override public boolean isCellEditable(int row, int column) {

• return column != 0;

+ return false;

}

};
DefaultTableCellRenderer renderer = new DefaultTableCellRenderer(){

Please someone let me know what the code review procedure is here, as I don't think I have permission yet to check in code.

[stoecker]

I would find it much better to reenable the edit feature instead of dropping it.

[stoecker]

Fixed in r1729.