Saving session results in IO Error

[ijsb]

Saving a session no longer works in the latest JOSMs, versions 7054 and today's 7068. It's still working for me in version 7028.

How to reproduce:

0. (Empty profile directory)
1. Start JOSM, enable Expert mode and create the advanced preference "session=true"
2. Create a new data layer and add a single node, just to have some data
3. File > Session > Save Session As...
4. In the dialog box, include Data Layer 1 (default setting) and select Save As
5. Enter a file name and select Save

Expected results:
-A correctly saved session file.

Actual results:
-An error dialog box "IO Error", "Could not save session file 'test.joz'. Error is: Stream closed".
-A stack trace (below).
-The created "test.joz" only contains "layers/01/data.osm". There is no "session.jos" and test.joz cannot be opened by JOSM.

---

Status report:

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-05-06 01:36:32
Last Changed Author: Don-vip
Revision: 7068
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-05-06 01:24:41 +0200 (Tue, 06 May 2014)
Last Changed Rev: 7068

Identification: JOSM/1.5 (7068 en) Linux Fedora release 20 (Heisenbug)
Memory Usage: 103 MB / 832 MB (66 MB allocated, but free)
Java version: 1.7.0_55, Oracle Corporation, OpenJDK 64-Bit Server VM

Stack trace:

ERROR: java.io.IOException: Stream closed
java.io.IOException: Stream closed
        at java.util.zip.ZipOutputStream.ensureOpen(ZipOutputStream.java:82)
        at java.util.zip.ZipOutputStream.putNextEntry(ZipOutputStream.java:175)
        at org.openstreetmap.josm.io.session.SessionWriter.write(SessionWriter.java:256)
        at org.openstreetmap.josm.io.session.SessionWriter.write(SessionWriter.java:243)
        at org.openstreetmap.josm.actions.SessionSaveAsAction.actionPerformed(SessionSaveAsAction.java:134)
        at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2018)
        at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2341)
        at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
        at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
        at javax.swing.AbstractButton.doClick(AbstractButton.java:376)

[Don-vip]

In 7070/josm:

see #9990 - show problem with unit tests

[bastiK]

See comment in ​http://josm.openstreetmap.de/doc/org/openstreetmap/josm/io/session/SessionWriter.ExportSupport.html#getOutputStreamZip(java.lang.String)

I can fix it later.

[Don-vip]

Yes I have seen :) I preferred to focus on non regression test before fixing it :)

[Don-vip]

In 7071/josm:

fix #9990 - Fix session writing regression