Modify

Opened 5 years ago

Closed 5 years ago

#9709 closed enhancement (fixed)

Fast adding preset to toolbar

Reported by: akks Owned by: team
Priority: normal Milestone: 14.02
Component: Core Version: latest
Keywords: GUI, toolbar, presets Cc:

Description

I have added "Add to toolbar" button to the preset dialog.
(we have similar functionality in search dialog, but there it it a checkbox)

Did not found similar tickets, so created this one for fixes or improvement discussion.

Attachments (0)

Change History (9)

comment:1 Changed 5 years ago by akks

Summary: Add preset to toolbarFast adding preset to toolbar

comment:2 Changed 5 years ago by akks

In 6838/josm:

see #9709: button for adding preset to main toolbar
(in upper right part of preset dialog)

comment:3 Changed 5 years ago by rickmastfan67

Hate to break this to you, but this has broken some presets that had already been added to the toolbar.

For instance, I had manually added the traffic lights, stop signs, motorway junction, and a few other tags and imagery sources to my toolbar via the 'Toolbar customization' inside of the preferences. In [6836], the buttons for the tags worked fine, but in the most recent 'nightly' of [6841], they are now all broken and throw up an exception in JOSM (the imagery buttons still worked however in [6841]) whenever I tried to click them to add the tag to the node/way. When I then reverted back to [6836], the buttons worked once again.

Hope this can be fixed as it unfortunately effects my work flow. And I was looking forward to using the new https setting from [6840], but can't till this bug is fixed.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-02-12 02:35:31
Last Changed Author: Don-vip
Revision: 6841
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-02-12 00:55:05 +0100 (Wed, 12 Feb 2014)
Last Changed Rev: 6841

Identification: JOSM/1.5 (6841 en) Windows 7 64-Bit
Memory Usage: 302 MB / 1820 MB (112 MB allocated, but free)
Java version: 1.7.0_51, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Xmx2048M]
Dataset consistency test: No problems found

Plugin: ImageryCache (30277)
Plugin: OpeningHoursEditor (30235)
Plugin: buildings_tools (30277)
Plugin: measurement (30277)
Plugin: mirrored_download (30197)
Plugin: notes (v0.9.1)
Plugin: osmarender (30277)
Plugin: reverter (30277)
Plugin: turnrestrictions (30277)
Plugin: undelete (30277)
Plugin: utilsplugin2 (30277)

java.lang.RuntimeException: Fatal: failed to locate image 'pin.???'. This is a serious configuration problem. JOSM will stop working.
	at org.openstreetmap.josm.tools.ImageProvider.get(ImageProvider.java:307)
	at org.openstreetmap.josm.tools.ImageProvider.get(ImageProvider.java:357)
	at org.openstreetmap.josm.gui.tagging.TaggingPreset$ToolbarButtonAction.<init>(TaggingPreset.java:511)
	at org.openstreetmap.josm.gui.tagging.TaggingPreset.createPanel(TaggingPreset.java:258)
	at org.openstreetmap.josm.gui.tagging.TaggingPreset.showDialog(TaggingPreset.java:323)
	at org.openstreetmap.josm.gui.tagging.TaggingPreset.actionPerformed(TaggingPreset.java:292)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$200(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

comment:4 Changed 5 years ago by akks

In 6842/josm:

fix broken icon path in preset dialog, see #9709

comment:5 Changed 5 years ago by akks

@rickmastfan67 : thank you very much for noticing!
It seems that building with Netbeans only is sometimes dangerous.

@team : can we update latest to avoid more bugreports?

comment:6 in reply to:  5 Changed 5 years ago by bastiK

Replying to akks:

@team : can we update latest to avoid more bugreports?

Done.

comment:7 Changed 5 years ago by akks

In 6844/josm:

see #9709: "Add to toolbar" in preset list context menu (F3-right click)

comment:8 Changed 5 years ago by Don-vip

Still something to do or can we close the ticket ? :)

comment:9 Changed 5 years ago by akks

Resolution: fixed
Status: newclosed

I guess nothing more (except editing help pages).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.