Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9690 closed defect (fixed)

re-think commit 6824 (removing individual "Edit X" strings)

Reported by: aceman Owned by: team
Priority: normal Milestone: 14.02
Component: Internal preset Version:
Keywords: i10n Cc:

Description

I don't know why commit 6824 was done and where is the ticket for it (nothing in the commit message). But it is completely wrong. "Edit {0}" is not localizable as the subject is translated differently when standalone (in the preset menu) and differently when used in this context. Also notice the subject is often in different extended form (in English) when in the "Edit X" string. I understand the need to reduce presents and reduce translation burden. But this is not thought out well enough. Please find a better solution.
E.g. for our language something like "{0}: properties" would work. But you need to consult all the other translators.

Attachments (0)

Change History (7)

comment:1 Changed 6 years ago by Don-vip

Off-topic:
You know, there are more polite ways to ask for this. Without denigrating Simon's good idea. Without pretending to know everything about the development of JOSM while you do obviously have no idea. Without giving the impression that we should be at your command when WE are JOSM developers, not you. Without taking apart the fun side which usually marks the open source development.

FYI, removing 500 strings is a huge improvement as it will ease the work of all translators and should reduce jar size in a notable way. You really should be more thankful about Simon's (very great) work. And no, we do not always need a ticket if we have an idea about improving our own software.

On-topic:
I agree "Edit X" is not perfect, it causes the same translation problems for French language. "Edit: X" or "Edit - X" could be a simple solution, although "X: properties" is fine, too.

Last edited 6 years ago by Don-vip (previous) (diff)

comment:2 in reply to:  1 ; Changed 6 years ago by aceman

Replying to Don-vip:

Off-topic:
You know, there are more polite ways to ask for this. Without denigrating Simon's good idea.
Without pretending to know everything about the development of JOSM while you do obviously have no idea.

Yes it is good idea, which I did admit. I just did not agree with the silent implementation. It was him who pretended he knows everything about languages and translations.
I do not think I was exceptionally impolite, but I have no problem to apologize to all of you guys. I like your work and therefore I am active in this bug tracker. It just sometimes is misunderstood :) Sorry about that.

Without giving the impression that we should be at your command when WE are JOSM developers, not you. Without taking apart the fun side which usually marks the open source development. And no, we do not always need a ticket if we have an idea about improving our own software.

Well, other open source projects have a habit of having a bug for each change so that people can discuss changes. But yes, it is your project and your rules. But then expect unhappy reports like this one :)

FYI, removing 500 strings is a huge improvement as it will ease the work of all translators and should reduce jar size in a notable way. You really should be more thankful about Simon's (very great) work.

I am thankful for all the work you guys do, that is why I have taken the effort to file so many tickets to improve JOSM further. And thank you for fixing many of them.

comment:3 in reply to:  2 ; Changed 6 years ago by simon04

Replying to aceman:

It was him who pretended he knows everything about languages and translations.

It has never been my intent to appear that way since I clearly don't.

In general I prefer a pragmatic solution which solves 95% or 99% nicely instead of a very complex solution for 99.9%.

I'm fine with "X: properties" or simply "X".

PS: Discussing every single change is not always the most motivating task to do …

comment:4 Changed 6 years ago by simon04

Milestone: 14.02

comment:5 Changed 6 years ago by simon04

Version: tested

comment:6 Changed 6 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6835/josm:

fix #9690 - fix i18n in presets. Just keep preset name

comment:7 in reply to:  3 Changed 6 years ago by Don-vip

Replying to simon04:

I'm fine with "X: properties" or simply "X".

+1 :) Done :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.