Modify

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#9650 closed enhancement (fixed)

Validate building=no

Reported by: naoliv Owned by: team
Priority: normal Milestone: 14.02
Component: Core validator Version:
Keywords: Cc:

Description

I was seeing some building=no here in Brazil and then I saw that there are more than 11000 uses of it http://taginfo.openstreetmap.org/tags/building=no#overview

It seems that it's thanks to iD https://github.com/openstreetmap/iD/issues/2111

building=no is the same as not using a building key. I can't think a valid use for this nor it makes sense to me.

If you agree, JOSM could validate this:

*[building = no] {
        throwWarning: tr("{0} is unnecessary", "{0.tag}");
        fixRemove: "{0.key}";
}


Attachments (0)

Change History (9)

comment:1 Changed 6 years ago by Don-vip

Milestone: 14.02

comment:2 Changed 6 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6788/josm:

fix #9650 - Validate building=no

comment:3 Changed 6 years ago by aceman

What about something that may look like a building but really isn't? You may want to mark it building=no to prevent anybody accidentally adding building=yes. Of course, I am not sure if =no is interpreted correctly by apps.

comment:4 Changed 6 years ago by anonymous

Is there any key/value combination that is considered to have/be building=yes by default? Then it would make sense to force a building=no.

Example: motorway is by default considered to be oneway=yes (then we don't need to use oneway=yes on it).
We use oneway=no if we want to force the opposite.

comment:5 Changed 6 years ago by mkoniecz

I encountered it for building visible on aerial imaginery, recently destroyed that recreated by some mappers.

comment:6 Changed 6 years ago by naoliv

Isn't note (http://wiki.openstreetmap.org/wiki/Key:note) the key that we use if we want to detail some information for other mappers? (say that "this building doesn't exist anymore, don't map it" in note, for example)

comment:7 Changed 5 years ago by anonymous

I've used this on several buildings that is visible on aerial imagery but is now demolished.
I had some drive-by mappers added those buildings before and this was the only way I could think of to prevent it.

comment:8 in reply to:  7 ; Changed 5 years ago by anonymous

Replying to anonymous:

I've used this on several buildings that is visible on aerial imagery but is now demolished.
I had some drive-by mappers added those buildings before and this was the only way I could think of to prevent it.

You need to use note and not add building=no

comment:9 in reply to:  8 Changed 5 years ago by skyper

Replying to anonymous:

Replying to anonymous:

I've used this on several buildings that is visible on aerial imagery but is now demolished.
I had some drive-by mappers added those buildings before and this was the only way I could think of to prevent it.

You need to use note and not add building=no

+1

I usually prefix it like historic:building=* and add end_date=*.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.