Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9607 closed defect (fixed)

defaultpreset: do not link image files, but include them in the *.jar file

Reported by: bastiK Owned by: team
Priority: major Milestone: 14.02
Component: Internal preset Version:
Keywords: Cc:

Description

some image files are linked in the default presets:

               <list_entry value="biofuel" icon="http://wiki.openstreetmap.org/w/images/6/6b/Bahnpirat-power_source-biofuel.svg" />
5196	                <list_entry value="biogas" icon="http://wiki.openstreetmap.org/w/images/6/6b/Bahnpirat-power_source-biofuel.svg" />
5197	                <list_entry value="biomass" icon="http://wiki.openstreetmap.org/w/images/6/6b/Bahnpirat-power_source-biofuel.svg" />
5198	                <list_entry value="coal" icon="http://wiki.openstreetmap.org/w/images/4/4b/Bahnpirat-power_source-coal.svg" />
5199	                <list_entry value="diesel" icon="http://wiki.openstreetmap.org/w/images/f/f7/Bahnpirat-power_source-oil.svg" />
5200	                <list_entry value="gas" icon="http://wiki.openstreetmap.org/w/images/e/e6/Bahnpirat-power_source-gas.svg" />
5201	                <list_entry value="gasoline" icon="http://wiki.openstreetmap.org/w/images/f/f7/Bahnpirat-power_source-oil.svg" />
5202	                <list_entry value="geothermal" icon="http://wiki.openstreetmap.org/w/images/e/ed/2020_stBN_powergensource_water.svg" />
5203	                <list_entry value="hydro" icon="http://wiki.openstreetmap.org/w/images/e/ed/2020_stBN_powergensource_water.svg" />
5204	                <list_entry value="nuclear" icon="http://wiki.openstreetmap.org/w/images/3/3e/2020_stBN_powergensource_nuclear.svg" />
5205	                <list_entry value="oil" icon="http://wiki.openstreetmap.org/w/images/f/f7/Bahnpirat-power_source-oil.svg" />
5206	                <list_entry value="osmotic" icon="http://wiki.openstreetmap.org/w/images/e/ed/2020_stBN_powergensource_water.svg" />
5207	                <list_entry value="solar" icon="http://wiki.openstreetmap.org/w/images/2/22/2020_stBN_powergensource_sun.svg" />
5208	                <list_entry value="tidal" icon="http://wiki.openstreetmap.org/w/images/e/ed/2020_stBN_powergensource_water.svg" />
5209	                <list_entry value="waste" icon="http://wiki.openstreetmap.org/w/images/2/2f/Bahnpirat-power_source-waste.svg" />
5210	                <list_entry value="wave" icon="http://wiki.openstreetmap.org/w/images/e/ed/2020_stBN_powergensource_water.svg" />
5211	                <list_entry value="wind" icon="http://wiki.openstreetmap.org/w/images/0/03/2020_stBN_powergensource_wind.svg" />
	        <item name="Gift" icon="http://openclipart.org/people/secretlondon/secretlondon_chocolate_present.svg" type="node,closedway">

They should be shipped in the JOSM binary if possible.

Attachments (0)

Change History (12)

comment:1 Changed 6 years ago by stoecker

Priority: minormajor

Who did that? JOSM's default preset should not contain any links!

comment:2 Changed 6 years ago by bastiK

In 6755/josm:

see #9607 - do not link image in defaultpreset

comment:3 in reply to:  1 Changed 6 years ago by bastiK

Resolution: duplicate
Status: newclosed

Replying to stoecker:

Who did that? JOSM's default preset should not contain any links!

Turns out, I did. :) (see [6136])

Let's reoopen #8847.

comment:4 Changed 6 years ago by Don-vip

Milestone: 14.01
Resolution: duplicatefixed

comment:5 Changed 6 years ago by Don-vip

Milestone: 14.0114.02
Resolution: fixed
Status: closedreopened

To fix in next tested version. Author of power icons has been contacted here: osmwiki:User_talk:Sergionaranja

comment:6 Changed 6 years ago by Don-vip

No answer, I've sent an e-mail.

comment:7 Changed 6 years ago by Don-vip

Still no answer, this time an OSM message :)

comment:9 Changed 6 years ago by Don-vip

https://trac.openstreetmap.org/browser/subversion/applications/share/map-icons/README

we expect new icons inserted here to be PD-Style-Licence

The readme does not state a particular license:
https://trac.openstreetmap.org/browser/subversion/applications/share/map-icons/2020iconset/readme.txt

Can we consider it is PD ?

comment:10 Changed 6 years ago by anonymous

hi

the author of 2020iconset here.
in the code of the .svg icons
there is a public domain statement
or ccBY, or should be.
use as you please.

take them from here
http://wiki.openstreetmap.org/wiki/Map_Icons/Map_Icons_Standards
(at the end of page)

i have no access to the subversion/aplications... etc.
so all icons should be changed to PD by someoneelse

comment:11 Changed 6 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 6799/josm:

fix #9607 - defaultpreset: do not link image files, but include them in the *.jar file

comment:12 Changed 6 years ago by Don-vip

Thanks Sergio !

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.