Modify

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#9601 closed enhancement (fixed)

[Patch] historic=wayside_shrine optional tags

Reported by: anonymous Owned by: team
Priority: normal Milestone: 15.02
Component: Internal preset Version:
Keywords: Cc:

Description

http://josm.openstreetmap.de/browser/josm/trunk/data/defaultpresets.xml#L5480

		<item name="Wayside Shrine" icon="presets/wayside_shrine.png" type="node,closedway">
			<label text="Edit Wayside Shrine" />
			<space />
			<key key="historic" value="wayside_shrine" />
			<key key="religion" value="christian" />
			<key key="building" value="wayside_shrine" />
			<text key="name" text="Name" />
			<text key="inscription" text="Inscription" />
			<text key="start_date" text="Erection/sacrification date" />
			<combo key="denomination" text="Denomination" values="roman_catholic,orthodox" />
			<combo key="amenity" text="Amenity" values="no,place of worship" />
			<combo key="tourism" text="Tourism" values="no,attraction" />
			<check key="ruins" text="Ruins" default="off" />
		</item>

Attachments (0)

Change History (8)

comment:1 Changed 6 years ago by simon04

According to http://taginfo.openstreetmap.org/tags/historic=wayside_shrine#combinations, only 10% of historic=wayside_shrine have religion=christian and only 7% have set building=*.

Before inclusion to JOSM core, the presence of those keys need to be discussed. Note that currently this preset only matches <10% of the existing wayside_shrines.

Presets/Historical_Objects and Presets/BENELUX also include a preset for wayside_shrine.

comment:2 Changed 6 years ago by anonymous

Only 10% have religion=christian because people don't know about that tags. I check OSM wiki and this tags are described and accepted. Building can be checkbox.

comment:3 Changed 6 years ago by simon04

True, but still, why should we restrict wayside shrines to the Christian religion? We could use a <combo> (maybe with christian as default) instead …
The tag building=wayside_shrine is used 103 times according to http://taginfo.openstreetmap.org/tags/building=wayside_shrine, so maybe we should neglect this for now?

comment:4 Changed 6 years ago by anonymous

I never see non Christian shrines but maybe exist. Why not new building tag for this? If school have, why not shrine.

comment:5 Changed 6 years ago by anonymous

I have people for tag this and they ask me for this preset. Can someone add this?

comment:6 Changed 6 years ago by simon04

We just released milestone:14.01 which means that we dod not add new features (esp. new presets) in the week before to finalize translations. And there are still open questions concerning some tags in this preset. –– Rome wasn't built in a day.

comment:7 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8016/josm:

fix #9601 - improve presets for historic=wayside_cross and historic=wayside_shrine

comment:8 Changed 5 years ago by Klumbumbus

Milestone: 15.02

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.