Modify

Opened 11 years ago

Closed 11 years ago

#9577 closed defect (fixed)

Not ideal fix for "way contains segment twice"

Reported by: naoliv Owned by: team
Priority: major Milestone: 14.01
Component: Core validator Version:
Keywords: Cc: simon04

Description

Using the attached file, select the way tagged with FIXME=twice, validate and apply the fix for the "way contains segment twice" error. Note how the geometry of the streets are changed (some pieces also disappear).
For cases like this the fix seems harmful (it changes the geometry and doesn't fix the real problem)

Maybe something like #9513 should be applied?

Attachments (1)

twice.osm.bz2 (28.8 KB ) - added by naoliv 11 years ago.

Download all attachments as: .zip

Change History (6)

by naoliv, 11 years ago

Attachment: twice.osm.bz2 added

comment:1 by Don-vip, 11 years ago

Cc: simon04 added
Milestone: 14.01
Priority: normalmajor

Ouch, release blocker. I'll try to have a look tomorrow, unless someone else manages to fix it before :)

comment:2 by simon04, 11 years ago

In 6693/josm:

see #9577 - Improve "Way contains segment twice" test (false-positives)

comment:3 by simon04, 11 years ago

In my opinion, way 255733376 from attachment:twice.osm.bz2 cannot be fixed automatically with reasonable efforts.

Based on #4959, the test was thought to remove duplicate way segments which are hard to spot/remove otherwise.

Since automatic fixes are hard to implement, maybe we should stick to a warning without a fix?

comment:4 by simon04, 11 years ago

In 6694/josm:

see #9577 - Highlight duplicate way segments of "Way contains segment twice" test

comment:5 by simon04, 11 years ago

Resolution: fixed
Status: newclosed

In 6722/josm:

fix #9577 - Remove automatic fix for "Way contains segment twice"

Since we highlight duplicate segments since r6694, it seems easier/safer to let the user manually fix this (rare?) error.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.