Modify

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#9539 closed defect (fixed)

JOSM in Windows doesn't load local validator files

Reported by: naoliv Owned by: team
Priority: normal Milestone: 14.01
Component: Core validator Version:
Keywords: Cc:

Description

I was seeing an user having a problem while trying to load a local .cfg validator file.

I have tested this with the currest stable r6502 and r6627, by using all the four combinations that I could think:

c:\dir\another\file.cfg
c:/dir/another/file.cfg
file://c:\dir\another\file.cfg
file://c:/dir/another/file.cfg

JOSM seems to see that the file is there (if I use a path that doesn't exist JOSM says that it could't read).
But there is nothing on console (error or any kind of info about the file) nor I can see any result from the local validator rules.

Attachments (0)

Change History (9)

comment:1 by stoecker, 11 years ago

Hmm, isn't it "file:///"?

comment:2 by naoliv, 11 years ago

file:/// is on Linux (and other *nix). The third / is part of the full path
/home/naoliv/foo.cfg is then file:///home/naoliv/foo.cfg
Right?

comment:3 by naoliv, 11 years ago

Googling and it seems to be file:/// (too?)
But if there isn't any warning or error from JOSM (that it couldn't read the file), then I understand that it's finding the file.

comment:4 by stoecker, 11 years ago

Hmm, did you add the proper comment line in the beginning? Otherwise JOSM handles the file as good/bad words file, the oldest supported format.

comment:5 by naoliv, 11 years ago

Damn the first line... :-)
Can I ask for some kind of info from JOSM when this happens?
For example, if it loads a .cfg file without this header, it could output (at the console) an info message, saying that the file will be interpreted as good/bad words.

comment:6 by stoecker, 11 years ago

Resolution: worksforme
Status: newclosed

We could only drop support for old format. As old-format has no header such a message would always occur. :-(

comment:7 by naoliv, 11 years ago

But only a message like it already does for mapcss files:

INFO: Adding /home/naoliv/.josm/validador-local.mapcss to tag checker

If you look at the console output, nothing is displayed about the .cfg file (if it was loaded as a proper validator or as the old-format).
It should be something like this:

if header is found:
     print "INFO: Adding $file to tag checker"
else:
     print "INFO: Adding $file as good/bad word"

(or some better phrase for the second case)

comment:8 by simon04, 11 years ago

Resolution: worksformefixed

In 6638/josm:

fix #9539 - *.cfg tag checker: display when custom files are loaded together with their type (tag checker, ignore tags, spellchecker)

comment:9 by Don-vip, 11 years ago

Milestone: 14.01

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.