Wrong validation result for highway tag on a node

[naoliv]

When validating some data today I saw a lot of "wrong highway tag on a node" warnings on nodes having highway=motorway_junction (​http://wiki.openstreetmap.org/wiki/Motorway_junction)

This is valid and the validator should ignore it.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-12-23 02:35:25
Last Changed Author: simon04
Revision: 6513
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-12-23 00:13:58 +0100 (Mon, 23 Dec 2013)
Last Changed Rev: 6513

Identification: JOSM/1.5 (6513 pt_BR) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 718 MB / 1756 MB (62 MB allocated, but free)
Java version: 1.7.0_45, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u45-2.4.3-4
VM arguments: [-Djava.net.useSystemProxies=true, -Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugin: AddrInterpolation (30034)
Plugin: Create_grid_of_ways (29854)
Plugin: FixAddresses (29971)
Plugin: ImageryCache (30135)
Plugin: OpeningHoursEditor (30117)
Plugin: PicLayer (29854)
Plugin: SimplifyArea (30145)
Plugin: buildings_tools (30057)
Plugin: editgpx (29854)
Plugin: geotools (30147)
Plugin: jts (29854)
Plugin: merge-overlap (30034)
Plugin: notes (v0.8)
Plugin: opendata (30097)
Plugin: pdfimport (29913)
Plugin: reverter (30031)
Plugin: tagging-preset-tester (30017)
Plugin: turnrestrictions (30145)
Plugin: undelete (29854)
Plugin: utilsplugin2 (30017)

[simon04]

In 6516/josm:

fix #9468 - validator: allow highway=motorway_junction on nodes

[aceman]

Didn't the patch throw out checking of motorway_link, primary_link, etc. ?

[simon04]

No, since the pattern is used as Pattern.compile().matcher().find(), and also assertMatch: "node highway=primary_link" succeeds.

[Don-vip]

I recognize that was not obvious and I asked myself the same question :) Good idea to insert assertions directly into the test :)