Modify

Opened 6 years ago

Closed 6 years ago

Last modified 2 years ago

#9407 closed enhancement (fixed)

[PATCH] Add Hungarian EOV projection and GRS67 ellipsoid

Reported by: BathoryPeter Owned by: team
Priority: normal Milestone: 13.12
Component: Core Version: latest
Keywords: Cc: bastiK

Description (last modified by BathoryPeter)

Additionally I've enabled ClarkeIGN in Projections.java and corrected flattening parameter of Bessel ellipsoid.

Hungarian HD72 / EOV proj4 parameters are from here: http://mercator.elte.hu/~saman/hu/okt/ol/
because of http://spatialreference.org/ref/epsg/23700/ writes a bad one.

Attachments (2)

hungarian_EOV_projection.diff (2.6 KB) - added by BathoryPeter 6 years ago.
hd72-eov_correction.diff (1.6 KB) - added by BathoryPeter 6 years ago.

Download all attachments as: .zip

Change History (17)

Changed 6 years ago by BathoryPeter

comment:1 Changed 6 years ago by BathoryPeter

Description: modified (diff)
Summary: [PATCH] Added Hungarian EOV projection and GRS67 ellipsoid[PATCH] Add Hungarian EOV projection and GRS67 ellipsoid

comment:2 Changed 6 years ago by simon04

Cc: bastiK added

bastiK, any concerns with applying this patch? I'd add a note in data/epsg that the parameters originate from http://mercator.elte.hu/~saman/hu/okt/ol/.

comment:3 in reply to:  2 Changed 6 years ago by BathoryPeter

Replying to simon04:

bastiK, any concerns with applying this patch? I'd add a note in data/epsg that the parameters originate from http://mercator.elte.hu/~saman/hu/okt/ol/.

Good idea, but how can we add note to epsg file? As I can see "#" marks the name of projection.

comment:4 Changed 6 years ago by Don-vip

Putting the note in the SVN commit message would be OK for me.

comment:5 Changed 6 years ago by bastiK

Resolution: fixed
Status: newclosed

In 6463/josm:

applied #9407 - Add Hungarian EOV projection and GRS67 ellipsoid (patch by BathoryPeter)

comment:6 in reply to:  4 Changed 6 years ago by bastiK

Replying to Don-vip:

Putting the note in the SVN commit message would be OK for me.

Sorry, forgot to put it in the commit message, but hopefully whoever needs to know will find this ticket.

Replying to simon04:

bastiK, any concerns with applying this patch?

It's fine, but I removed the "+datum=HD72" property because it is redundant and not defined anywhere. In addition I reverted the change to Bessel1841 as no reason or source was given.

comment:7 Changed 6 years ago by simon04

The changed value for Bessel 1841 is written on https://en.wikipedia.org/wiki/Bessel_ellipsoid, but no source is given on that page neither.

comment:8 Changed 6 years ago by Don-vip

Milestone: 13.12 (6502)

Changed 6 years ago by BathoryPeter

Attachment: hd72-eov_correction.diff added

comment:9 Changed 6 years ago by BathoryPeter

Resolution: fixed
Status: closedreopened
  • More precise GRS67 flattening parameter (source: epsg.org)

comment:10 Changed 6 years ago by bastiK

This site seems to have Bursa-Wolf parameters with better maximum error. It references a publication by the same authors.

comment:11 in reply to:  10 ; Changed 6 years ago by BathoryPeter

Replying to bastiK:
You are right, Bursa-Wolf parameters are exist for HD72.
As biggest GIS softwares (Postgis, QGIS, Proj4) uses 3-parameter form (with corrected parameters), for better interoperability, Hungarian OSM community suggest to use the same definition.

comment:12 Changed 6 years ago by bastiK

Resolution: fixed
Status: reopenedclosed

In 6974/josm:

applied #9407 - fix for Hungarian EOV projection (patch by BathoryPeter)

comment:13 Changed 6 years ago by bastiK

In 6975/josm:

see #9407 - remove unnecessary zeros

comment:14 in reply to:  11 Changed 6 years ago by bastiK

Replying to BathoryPeter:

As biggest GIS softwares (Postgis, QGIS, Proj4) uses 3-parameter form (with corrected parameters), for better interoperability, Hungarian OSM community suggest to use the same definition.

Sounds reasonable.

comment:15 Changed 2 years ago by stoecker

Milestone: 13.12 (6502)13.12

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.