Modify

Opened 7 years ago

Closed 19 months ago

Last modified 2 weeks ago

#9257 closed enhancement (fixed)

detect highway=footway, highway=pedestrian with foot=yes (and highway=cycleway with bicycle=yes) [PATCH] regression fixed

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 19.03
Component: Core validator Version:
Keywords: highway footway cycleway bicycle yes designated Cc:

Description (last modified by mkoniecz)

This kind of things should never happen. "no" value is already detected in analogous case.

highway=footway with foot=designated (and highway=cycleway with bicycle=designated) is pointless but rather harmless

example of manual detection and fixing of highway=pedestrian with foot=yes: osmwww:browse/changeset/19303898

Attachments (0)

Change History (21)

comment:1 Changed 7 years ago by mkoniecz

Description: modified (diff)
Summary: detect highway=footway with foot=yes or foot=no (and highway=cycleway with bicycle=yes or bicycle=no)detect highway=footway with foot=yes (and highway=cycleway with bicycle=yes)

comment:2 Changed 7 years ago by mkoniecz

osmwww:browse/changeset/19074122

example of fix after a manual detection

comment:3 Changed 7 years ago by mkoniecz

similar #9380 (" detect and remove motor_vehicle = yes from highway=motorway, primary, secondary, tertiary etc ") is implemented

comment:4 Changed 7 years ago by mkoniecz

Description: modified (diff)
Summary: detect highway=footway with foot=yes (and highway=cycleway with bicycle=yes)detect highway=footway, highway=pedestrian with foot=yes (and highway=cycleway with bicycle=yes)

comment:5 Changed 20 months ago by Don-vip

Keywords: cycleway added

comment:6 Changed 20 months ago by Don-vip

Keywords: highway footway bicycle yes designated added
Milestone: 19.03

comment:7 Changed 20 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 14904/josm:

fix #9257 - detect highway=footway|pedestrian with foot=yes|designated (and highway=cycleway with bicycle=yes|designated)

comment:8 Changed 20 months ago by anonymous

Resolution: fixed
Status: closedreopened

If a way tagged with

access=no
bicycle=designated
highway=cycleway

the validator wants to (auto)fix it to access=no, which is not good.
See it on overpass https://overpass-turbo.eu/s/Han

comment:9 Changed 20 months ago by mkoniecz

Thanks for spotting and reporting this!

comment:10 Changed 20 months ago by Don-vip

I don't get it, what does such tagging mean? I don't see the difference between access=no bicycle=designated highway=cycleway and access=no highway=cycleway. In both cases it's a cycleway where you can't go?

comment:11 Changed 20 months ago by mkoniecz

bicycle is more specific tag than access and overrides it.

access=no bicycle=designated highway=cycleway has

implied bicycle=designated
overriden by access=no
overriden for bicycles by bicycle=designated

See https://wiki.openstreetmap.org/wiki/Key:access

comment:12 Changed 19 months ago by mkoniecz

Looking at validator file https://josm.openstreetmap.de/browser/josm/trunk/data/validator/unnecessary.mapcss I see need for one more related change

*[motor_vehicle?][vehicle!=no][access!=no][bicycle_road!=yes][highway =~ /^(motorway|motorway_link|trunk|trunk_link|primary|primary_link|secondary|secondary_link|tertiary|tertiary_link|unclassified|residential|service|living_street)$/],

into

*[motor_vehicle?][vehicle!=no][!vehicle][!access][bicycle_road!=yes][highway =~ /^(motorway|motorway_link|trunk|trunk_link|primary|primary_link|secondary|secondary_link|tertiary|tertiary_link|unclassified|residential|service|living_street)$/],

Also

way[bicycle =~ /^(yes|designated)$/][highway=cycleway],

into

way[bicycle =~ /^(yes|designated)$/][highway=cycleway][!vehicle][!access],

Also

way[foot =~ /^(yes|designated)$/][highway =~ /^(footway|pedestrian)$/],

into

way[foot =~ /^(yes|designated)$/][highway =~ /^(footway|pedestrian)$/][!access],


Tagging highway=pedestrian access=no foot=designated is a bad idea and deserves warning if that is popular, but is not improved by removing foot tag.

comment:13 Changed 19 months ago by mkoniecz

If that would be useful I will produce patch in a near future ( https://github.com/matkoniecz/josm/blob/mirror/data/validator/unnecessary.mapcss ).

Last edited 19 months ago by mkoniecz (previous) (diff)

comment:14 Changed 19 months ago by mkoniecz

For now untested patch: https://github.com/matkoniecz/josm/commit/cac3dac84a16a08974be10213e25c00c9d8603f8.patch (I need to figure out how to disable default validator and enable custom one to test it)

comment:15 Changed 19 months ago by mkoniecz

Patch is now ready and tested.

comment:16 Changed 19 months ago by mkoniecz

Summary: detect highway=footway, highway=pedestrian with foot=yes (and highway=cycleway with bicycle=yes)detect highway=footway, highway=pedestrian with foot=yes (and highway=cycleway with bicycle=yes) [PATCH] regression fixed

comment:17 Changed 19 months ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 14918/josm:

fix #9257 - detect highway=footway, highway=pedestrian with foot=yes (and highway=cycleway with bicycle=yes) (PATCH by mkoniecz)

comment:18 Changed 19 months ago by Klumbumbus

In 14942/josm:

see #9257 - fix warning message, regression of r14918

comment:19 Changed 7 months ago by Klumbumbus

In 16232/josm:

see #9257 - Fix warning message

comment:20 Changed 4 months ago by anonymous

This is a false positive, please remove this form the validator (detection of footway with foot=yes as "unnecessary tag").

The value for foot is NOT "yes" by definition, but van be "yes", "permissive" or even "private" / "customers"
"yes" has a specific meaning in OSM, and can be used to distinguish footways with legally-protected access (foot=yes) from footways where permission can be revoked at any time without a legal procedure (foot=permissive).

This is also described in the main-wiki page for key: accesshttps://wiki.openstreetmap.org/wiki/Key:access#Transport_mode_restrictions:
"For example, to distinguish a footway with open access from one with private access, use tags like foot=yes instead of access=yes. "

By suggesting that such tags are unnecessary (and even deleting it with the auto-fix option) valid data is removed from the database, and mappers are encouraged to further delete such tags so please correct this false positive with priority. The same goes fot bicycle=yes on a cycleway. Thanks!


comment:21 Changed 2 weeks ago by Klumbumbus

In 17147/josm:

fix #19862, see #9257 - Remove controversial warning about unnecessary foot|bicycle=yes|designated together with highway=footway|pedestrian|cycleway

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.