Modify

Opened 12 years ago

Closed 11 years ago

Last modified 8 years ago

#9178 closed enhancement (fixed)

speed camera preset dialog not appearing

Reported by: jphilipz Owned by: team
Priority: normal Milestone: 13.12
Component: Internal preset Version:
Keywords: Cc:

Description

I set the node and went to the speed camera preset and the dialog didnt appear, but it did set highway=speed_camera. So i tried clicking on the properties underlined text 'Highways/Waypoint/Speed Camera' and still no dialog, but it would add a change in the command stack as 'set 1 properties for 0 objects'. Tried this on the development and stable releases. I'm running josm on java 7.

Attachments (0)

Change History (10)

comment:1 by AlfonZ, 12 years ago

Component: CoreInternal preset

This is the correct behaviour.
All the Speed Camera preset does is set highway=speed_camera, there are currently no other tags to set for it. In order for the preset dialog to appear, there have to be other tags.

Looking at Tag:highway=speed_camera wiki, there is only one other tag mentioned - maxspeed.
Are you suggesting it should be added to the preset?

in reply to:  1 ; comment:2 by skyper, 12 years ago

Replying to ypharis@…:

I set the node and went to the speed camera preset and the dialog didnt appear, but it did set highway=speed_camera. So i tried clicking on the properties underlined text 'Highways/Waypoint/Speed Camera' and still no dialog, but it would add a change in the command stack as 'set 1 properties for 0 objects'

Zero objects is wrong. It should be one. Or no entry in the command stack as nothing was changed in this special case.

Replying to AlfonZ:

Looking at Tag:highway=speed_camera wiki, there is only one other tag mentioned - maxspeed.
Are you suggesting it should be added to the preset?

Do not think it is needed as the maxspeed should be tagged on the highway.
How should I get the information of the exact maxspeed ?

in reply to:  2 comment:3 by AlfonZ, 12 years ago

Replying to skyper:

Replying to ypharis@…:

I set the node and went to the speed camera preset and the dialog didnt appear, but it did set highway=speed_camera. So i tried clicking on the properties underlined text 'Highways/Waypoint/Speed Camera' and still no dialog, but it would add a change in the command stack as 'set 1 properties for 0 objects'

Zero objects is wrong. It should be one. Or no entry in the command stack as nothing was changed in this special case.

Other workflows that create empty (0 objects changed) command:

  • Copy object(s), Paste tags onto the same object(s)
  • in the properties window - Edit tag, confirm the same value
  • in the propesties window - right click on a tag, Copy value, right click on the same tag, Paste value

in reply to:  1 ; comment:4 by jphilipz, 12 years ago

Replying to AlfonZ:

Looking at Tag:highway=speed_camera wiki, there is only one other tag mentioned - maxspeed.
Are you suggesting it should be added to the preset?

Yes it would be nice to have maxspeed in the dialog, as i'm adding this tag manually. I enjoy the dialogs as it has links to the wiki page of the tag, which make it easier to lookup if i'm doing things right, as i'm a new user.

in reply to:  4 ; comment:5 by skyper, 12 years ago

Replying to ypharis@…:

Replying to AlfonZ:

Looking at Tag:highway=speed_camera wiki, there is only one other tag mentioned - maxspeed.
Are you suggesting it should be added to the preset?

Yes it would be nice to have maxspeed in the dialog, as i'm adding this tag manually.

Please tell me the maxspeed of the speed camera then. It is definitely not the signed maxspeed but higher. Think this information is useless until you will define the "real" limit either by the exact value (maxspeed) or by a new key tolerance or similar which I would prefer.

I enjoy the dialogs as it has links to the wiki page of the tag, which make it easier to lookup if i'm doing things right, as i'm a new user.

You can use the right click menu in the properties toggle dialog to open the OSM wiki page for the selected key in your web browser.

in reply to:  5 comment:6 by jphilipz, 12 years ago

Replying to skyper:

Please tell me the maxspeed of the speed camera then. It is definitely not the signed maxspeed but higher. Think this information is useless until you will define the "real" limit either by the exact value (maxspeed) or by a new key tolerance or similar which I would prefer.

Well of course we have maxspeed street signs, but those who drive in an area will know the maxspeed of a speed camera, as localities are strict according to the maxspeed of the signs, or where i live, they give an addition 10mph in cities and 20 on highways. I believe we all have been flashed by speed cameras and become aware of what the maxspeed will be.

You can use the right click menu in the properties toggle dialog to open the OSM wiki page for the selected key in your web browser.

thanks for this tip.

comment:7 by skyper, 12 years ago

Type: defectenhancement

comment:8 by Don-vip, 11 years ago

Resolution: fixed
Status: newclosed

In 6480/josm:

fix #9178 - presets: add maxspeed to highway=speed_camera

comment:9 by Don-vip, 11 years ago

Milestone: 13.12 (6502)

comment:10 by stoecker, 8 years ago

Milestone: 13.12 (6502)13.12

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.