Relation editor: Applying a preset while editing tags can create empty tags (subsequently ignored)

[madnag4u]

Steps to reproduce bug:

1. Create new relation.
2. Give the tag type=public_transport in the relation editor.
3. Open Public Transport preset dialog box when it appears near the top of the relation editor.
4. Give some name in the Name field.
5. Hit Apply Preset.

One expects to see the tag name=some name to be imported into the relation editor. But I see only the value some name getting copied and not the name key.

[AlfonZ]

Having just tag type=public_transport was not enough to identify and thus did not show the Public transport preset.
However, it can be reproduced with other relation types as well:

1. Create new relation.
2. Add the tag type=multipolygon in the relation editor, Relations/Multipolygon preset shows up.
3. Leave the editing cursor in the tags editor in the Key column.
4. Open the Relations/Multipolygon preset.
5. Fill a name in the Multipolygon preset dialog, press Apply Preset.
6. The name will be added to the tags editor, name key will not, it will be overwritten by the editing cursor.
7. If you press Esc now, the editing (of empty key) gets cancelled and key will be filled with correct name.
   Maybe this cancelling should be done automatically after applying the preset?

In the step 3., if the cursor is left in the Value column, applying the preset will set the key but the value will get overwritten by editing cursor.

[daganzdaanda]

I just tried and can confirm that behaviour with the current stable (Revision: 7995).

[michael2402]

Happens in current stable, also when pasting tags.

I'll fix it on the way.

[michael2402]

I fixed this 3 years back, forgot to close