Modify

Opened 9 years ago

Closed 3 years ago

Last modified 3 years ago

#9164 closed enhancement (fixed)

[PATCH] add more values for historic=*

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 20.07
Component: Internal preset Version:
Keywords: historic church Cc: lutz, escada, Klumbumbus

Description (last modified by skyper)

tags/historic=church is not really popular (barely over 1000 in existence), but historic key is already in presets and church tag makes sense, and AFAIK there is no better alternative for historic churches (both in presets and among more popular tags).

Attachments (4)

#9164_--_Historic_presets.patch (12.8 KB) - added by hiddewie 3 years ago.
#9164_--_Historic_presets1.patch (31.8 KB) - added by hiddewie 3 years ago.
9164_milestone.png (372 bytes) - added by Klumbumbus 3 years ago.
#9164_--_Historic_presets2.patch (37.0 KB) - added by hiddewie 3 years ago.
with milestone from nodist

Download all attachments as: .zip

Change History (31)

comment:1 Changed 9 years ago by Don-vip

Component: CoreInternal preset

comment:2 Changed 9 years ago by skyper

There exists an external presets for historic objects.

comment:3 Changed 9 years ago by skyper

Cc: lutz escada added
Keywords: historic added

Maybe, we can get the auther(s) of the external preset to submit a patch for the internal preset. There are quite some duplicate entries ATM and at least the entries which are already in the internal preset could be updated/expended in favour of the duplicat entries in the external preset.

comment:4 Changed 6 years ago by Don-vip

Summary: add historic=church to presetsadd historic=church

comment:5 Changed 6 years ago by Don-vip

Keywords: church added

comment:6 Changed 3 years ago by skyper

Description: modified (diff)
Summary: add historic=churchadd more values for historic=*

While fort is in defaultpresets some values with higher number and wiki pages are missing:

  1. charcoal_pile
  2. citywalls
  3. heritage
  4. mine_shaft
  5. shieling
  6. mine
  7. manor
  8. milestone
  9. church
  10. city_gate

Changed 3 years ago by hiddewie

comment:8 Changed 3 years ago by hiddewie

Patch added for all historic items with enough tag usage.

Icons:

comment:9 Changed 3 years ago by hiddewie

Summary: add more values for historic=*[PATCH] add more values for historic=*

comment:10 Changed 3 years ago by simon04

Cc: Klumbumbus added
Milestone: 20.06

comment:11 Changed 3 years ago by Klumbumbus

Every new item needs an own icon and not share an icon with another item thats confusing.

comment:12 Changed 3 years ago by Klumbumbus

Also the milestone icon doesn't work within JOSM.

comment:13 Changed 3 years ago by Klumbumbus

Milestone: 20.0620.07

comment:14 Changed 3 years ago by hiddewie

I have fixed some of the icons. Also they have been deduplicated from their non-historic counterparts.

The mine and mineshaft (historic) still use the same icon, just like mine and mineshaft (non-historic) use the same icon.

Changed 3 years ago by hiddewie

comment:15 Changed 3 years ago by Klumbumbus

Thx. The milestone icon still doesn't work well within JOSM though.

Last edited 3 years ago by Klumbumbus (previous) (diff)

Changed 3 years ago by Klumbumbus

Attachment: 9164_milestone.png added

comment:16 Changed 3 years ago by hiddewie

OK that is strange. I took the milestone SVG from nodist, which does work well.

Changed 3 years ago by hiddewie

with milestone from nodist

comment:17 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 16748/josm:

fix #9164 - Add more historic presets (patch by hiddewie, modified)

  • historic=citywalls (internal icon reused)
  • historic=city_gate (icon https://wiki.openstreetmap.org/wiki/File%3ACity-gate-14.svg, color changed, PD and CC0 licensed)
  • historic=manor (icon from https://wiki.openstreetmap.org/wiki/File:Manor-14.svg, PD and CC0 licensed)
  • historic=church (icon derived from internal icon, PD and CC0 licensed)
  • historic=charcoal_pile (icon derived from internal icon, PD and CC0 licensed)
  • historic=mine (icon derived from internal icon, PD and CC0 licensed)
  • historic=mine_shaft (icon derived from internal icon, PD and CC0 licensed)
  • historic=shieling (icon derived from internal icon, PD and CC0 licensed)
  • historic=milestone (icon self created, PD and CC0 licensed)

comment:18 Changed 3 years ago by Klumbumbus

I created a new milestone icon because we used that icon from nodist for railway=milestone or highway=milestone in the past and that might be confusing. I changed the historic mine icon, flipped it. I saw this on printed maps for disused mines.

What are the icon sources of church, charcoal_pile, mine and shieling? Or which did you create yourself?

comment:19 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: closedreopened

comment:20 Changed 3 years ago by hiddewie

Perfect, thanks.

Church, charcoal_pile, mine + mine_shaft and shieling are all modified icons from the JOSM code base, so under the same license.

comment:21 Changed 3 years ago by Klumbumbus

Thx.

comment:22 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

comment:23 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: closedreopened

Some icons do not work. Under investigation...

comment:24 Changed 3 years ago by Klumbumbus

In 16753/josm:

see #9164 - fix icon display

comment:25 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

In 16754/josm:

fix #9164 - fix icon display for real

comment:26 Changed 3 years ago by Klumbumbus

That was tricky ;)

comment:27 in reply to:  18 Changed 3 years ago by gaben

Replying to Klumbumbus:

I changed the historic mine icon, flipped it.

:D

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.