#9164 closed enhancement (fixed)
[PATCH] add more values for historic=*
Reported by: | mkoniecz | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 20.07 |
Component: | Internal preset | Version: | |
Keywords: | historic church | Cc: | lutz, escada, Klumbumbus |
Description (last modified by )
tags/historic=church is not really popular (barely over 1000 in existence), but historic key is already in presets and church tag makes sense, and AFAIK there is no better alternative for historic churches (both in presets and among more popular tags).
Attachments (4)
Change History (31)
comment:1 Changed 9 years ago by
Component: | Core → Internal preset |
---|
comment:2 Changed 9 years ago by
comment:3 Changed 9 years ago by
Cc: | lutz escada added |
---|---|
Keywords: | historic added |
Maybe, we can get the auther(s) of the external preset to submit a patch for the internal preset. There are quite some duplicate entries ATM and at least the entries which are already in the internal preset could be updated/expended in favour of the duplicat entries in the external preset.
comment:4 Changed 6 years ago by
Summary: | add historic=church to presets → add historic=church |
---|
comment:5 Changed 6 years ago by
Keywords: | church added |
---|
comment:6 Changed 3 years ago by
Description: | modified (diff) |
---|---|
Summary: | add historic=church → add more values for historic=* |
While fort is in defaultpresets some values with higher number and wiki pages are missing:
comment:7 Changed 3 years ago by
Usage of all those other historic tags: https://taghistory.raifer.tech/#***/historic/church&***/historic/city_gate&***/historic/manor&***/historic/church&***/historic/charcoal_pile&***/historic/mine&***/historic/mine_shaft&***/historic/shieling&***/historic/city_gate&***/historic/milestone&***/historic/milestone
Changed 3 years ago by
Attachment: | #9164_--_Historic_presets.patch added |
---|
comment:8 Changed 3 years ago by
Patch added for all historic items with enough tag usage.
Icons:
- charcoal_pile has no icon
- citywalls same visualization as barrier = city_wall
- mine & mine_shaft have same icon (existing mine icon)
- shieling has no icon
- manor has OSM icon https://wiki.openstreetmap.org/wiki/File:Manor-14.svg
- milestone has self created adapted boundary_stone icon
- church has existing church icon
- city_gate has OSM icon https://wiki.openstreetmap.org/wiki/File:City-gate-14.svg
comment:9 Changed 3 years ago by
Summary: | add more values for historic=* → [PATCH] add more values for historic=* |
---|
comment:10 Changed 3 years ago by
Cc: | Klumbumbus added |
---|---|
Milestone: | → 20.06 |
comment:11 Changed 3 years ago by
Every new item needs an own icon and not share an icon with another item thats confusing.
comment:13 Changed 3 years ago by
Milestone: | 20.06 → 20.07 |
---|
comment:14 Changed 3 years ago by
I have fixed some of the icons. Also they have been deduplicated from their non-historic counterparts.
The mine and mineshaft (historic) still use the same icon, just like mine and mineshaft (non-historic) use the same icon.
Changed 3 years ago by
Attachment: | #9164_--_Historic_presets1.patch added |
---|
comment:15 Changed 3 years ago by
Changed 3 years ago by
Attachment: | 9164_milestone.png added |
---|
comment:16 Changed 3 years ago by
OK that is strange. I took the milestone SVG from nodist, which does work well.
Changed 3 years ago by
Attachment: | #9164_--_Historic_presets2.patch added |
---|
with milestone from nodist
comment:18 follow-up: 27 Changed 3 years ago by
I created a new milestone icon because we used that icon from nodist for railway=milestone or highway=milestone in the past and that might be confusing. I changed the historic mine icon, flipped it. I saw this on printed maps for disused mines.
What are the icon sources of church, charcoal_pile, mine and shieling? Or which did you create yourself?
comment:19 Changed 3 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:20 Changed 3 years ago by
Perfect, thanks.
Church, charcoal_pile, mine + mine_shaft and shieling are all modified icons from the JOSM code base, so under the same license.
comment:22 Changed 3 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:23 Changed 3 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Some icons do not work. Under investigation...
There exists an external presets for historic objects.