"Precache imagery tiles" only works with WMS

[sybren]

I want to precache imagery tiles along a GPX track. I selected Imagery -> OpenStreetMap (Mapnik), which added an imagery layer. I've loaded the GPX into JOSM, then right-clicked and selected "Precache imagery tiles along this track". It gives me an error message stating "There are no imagery layers", when there clearly is one.

Googling this error message led me to ​http://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/gui/layer/gpx/DownloadWmsAlongTrackAction.java, which shows that the code actually only works for WMS layers. This is confusing, as the user interface mentions "imagery layers" and not "WMS imagery layers".

Please also include support for TMS and other imagery layers.

Tested on version 6238 on Windows 7 with Java 7.

[Don-vip]

skip milestone 15.06

[wiktorn]

In 8526/josm:

Introduce WMS layer based on TMS. (closes: #11255)

HEADS UP: After this patch you need to manually remove JAX-B generated file/class: org/w3/_2001/xmlschema/Adapter1.java to compile the tree again.

• create AbstractTileSourceLayer based on TMSLayer as a base for TMS, WMS and (future) WMTS layers, (addresses #11459)
• WMS layer now uses JCS Caching (closes: #7363)
• introduce new conversion methods in TileSource, that convert both X and Y (lat and lon) in one call. This is necessary for other than PseudoMercator projections
  • introduce TileXY class that represents X and Y indexes of tile in tile matrix/space
  • mark old conversion methods as deprecated
  • refactor JMapViewer and JOSM to new methods
  • change use of Coordinate class to ICoordinate where appropiate
• extract CachedAttributionBingAerialTileSource to separate file
• create TemplatedWMSTileSource that provides the WMS Layer with square (according to current projection) tiles (closes: #11572, closes: #7682, addresses: #5454)
• implemented precaching imagery along GPX track for AbstractTileSourceLayer, so now it work for both - WMS and TMS (closes: #9154)
• implemented common righ-click menu on map view, as well on layer list (closes #3591)
• create separate build commands for JMapViewer classes to easily spot, when josm classes are used within JMapViewer
• remove unnecessary classes of previous WMS implementation - GeorefImage, wms-cache.xsd (and JAXB task from build), WMSCache, WMSRequest, WMSGrabber, HTMLGrabber, WMSException

[Don-vip]

Milestone renamed