Modify

Opened 10 years ago

Closed 10 years ago

Last modified 6 years ago

#9119 closed defect (fixed)

[patch] regression: false warning about incline up/down

Reported by: skyper Owned by: team
Priority: normal Milestone: 13.11
Component: Core validator Version: latest
Keywords: incline up down Cc:

Description

I get false warnings about "unusual" incline value but the values are up and down

  1. create a new layer
  2. add a way and tag it with highway=*;incline=up
  3. run validator
Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-09-27 01:34:30
Last Changed Author: Don-vip
Revision: 6266
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-09-27 02:01:48 +0200 (Fri, 27 Sep 2013)
Last Changed Rev: 6266

Identification: JOSM/1.5 (6266 en) Linux Debian GNU/Linux 7.1 (wheezy)
Memory Usage: 399 MB / 672 MB (146 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u25-2.3.10-1~deb7u1
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (29854)
Plugin: conflation (0.1.6)
Plugin: jts (29854)
Plugin: mirrored_download (29854)
Plugin: notes (v0.5)
Plugin: openstreetbugs (29854)
Plugin: reverter (29854)
Plugin: undelete (29854)
Plugin: utilsplugin2 (29854)
Plugin: wikipedia (29854)

Attachments (0)

Change History (4)

comment:1 Changed 10 years ago by AlfonZ

Summary: regression: false warning about incline up/down[patch] regression: false warning about incline up/down

Typo in r6251.

  • data/tagchecker.cfg

     
    197197way : W : frequency == * && frequency != /^(0|[1-9][0-9]*(\.[0-9]+)?)( (kHz|MHz|GHz|THz))?$/  # unusual frequency specification
    198198way : W : gauge == * && gauge != /^([1-9][0-9]{1,3}(;[1-9][0-9]{1,3})*|broad|standard|narrow)$/  # unusual train track gauge; use mm with no separator
    199199# the numbers for percentage and degrees include could probably be bracketed a bit more precisely
    200 way : W : incline == * && include != /^(up|down|-?([0-9]+?(\.[1-9]%)?|100)[%°]?)$/  # unusual incline; use percentages/degrees or up/down
     200way : W : incline == * && incline != /^(up|down|-?([0-9]+?(\.[1-9]%)?|100)[%°]?)$/  # unusual incline; use percentages/degrees or up/down

comment:2 Changed 10 years ago by stoecker

Resolution: fixed
Status: newclosed

In r6269.

Last edited 10 years ago by stoecker (previous) (diff)

comment:3 Changed 10 years ago by Don-vip

Milestone: 13.11 (6383)

comment:4 Changed 6 years ago by stoecker

Milestone: 13.11 (6383)13.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.