#9062 closed enhancement (fixed)
[patch] house number hidden when historic tag is added
Reported by: | Gilbert54 | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 13.11 |
Component: | Internal mappaint style | Version: | tested |
Keywords: | historic name potlatch2 | Cc: |
Description
What steps will reproduce the problem?
- draw the area for a house
- add address info, including addr:housenumber: now the house nr is shown inside the house area
- add historic=house or historic=yes: the house number is not shown anymore
What is the expected result?
The house number visibility should not be affected by the presence of the historic tag - or any other tag for that matter
What happens instead?
The house number is not shown anymore when the historic tag is added. The addr:housenumber tag is still there with the correct value, the number is just not shown anymore on the editor map.
Please provide any additional information below. Attach a screenshot if
possible.
Pick any house which has the heritage tag and play with the heritage tag to see the effect.
http://www.openstreetmap.org/browse/changeset/17748082
Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2013-08-07 01:35:24 Last Changed Author: Don-vip Revision: 6115 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2013-08-07 00:04:24 +0200 (Wed, 07 Aug 2013) Last Changed Rev: 6115 Identification: JOSM/1.5 (6115 en_GB) Windows 7 64-Bit Memory Usage: 494 MB / 494 MB (155 MB allocated, but free) Java version: 1.7.0_25, Oracle Corporation, Java HotSpot(TM) Client VM VM arguments: [-Xms16m, -Xmx512m] Dataset consistency test: No problems found Plugin: buildings_tools (29778) Plugin: download_along (29778) Plugin: notes (0.3) Plugin: print (29529) Plugin: terracer (29771) Plugin: utilsplugin2 (29771)
Attachments (3)
Change History (11)
comment:1 Changed 9 years ago by
Component: | Core → Internal mappaint style |
---|---|
Keywords: | historic name display added |
Changed 9 years ago by
Attachment: | 9062-JOSMStyle.png added |
---|
Changed 9 years ago by
Attachment: | 9062-Potlatch2Style.png added |
---|
comment:2 Changed 9 years ago by
comment:3 follow-up: 4 Changed 9 years ago by
Owner: | changed from team to Gilbert54 |
---|---|
Status: | new → needinfo |
comment:4 Changed 9 years ago by
Replying to AlfonZ:
Sorry, I thought that I had sent a response. Yes, I'm using the Potlatch 2 style. In fact I use most of the time JOSM style and Potlatch 2 style combined. Bad habit...
Regards,
Gilbert
Changed 9 years ago by
Attachment: | 9062-name2auto.patch added |
---|
comment:5 Changed 9 years ago by
Keywords: | potlatch2 added; template_report display removed |
---|---|
Owner: | changed from Gilbert54 to team |
Status: | needinfo → new |
Summary: | house number hidden when historic tag is added → [patch] house number hidden when historic tag is added |
Type: | defect → enhancement |
Patch 9062-name2auto.patch changes the text property from name
to auto
for all ways.
As name
is by default the second tag in mappaint.nameOrder
, the currently rendered names are not likely to be affected.
I am not sure though, how much customization to the Potlatch2 style is desired in JOSM.
In the meantime you can add custom style area[historic]:closed { text: auto; }
, which displays the housenumber just for the historic
tag.
EDT: You can also try reordering the JOSM Internal Style and Potlatch2 style. While this displays the housenumber, it changes the visual style as well.
comment:7 Changed 9 years ago by
Milestone: | → 13.11 (6383) |
---|
Trying with http://www.openstreetmap.org/browse/way/228422283 I can see the housenumber.
Are you by any chance referring to the Potlatch2 style, that indeed doesn't show the housenumber with
historic
tag?