[patch] house number hidden when historic tag is added

[Gilbert54]

What steps will reproduce the problem?

1. draw the area for a house
2. add address info, including addr:housenumber: now the house nr is shown inside the house area
3. add historic=house or historic=yes: the house number is not shown anymore

What is the expected result?
The house number visibility should not be affected by the presence of the historic tag - or any other tag for that matter

What happens instead?
The house number is not shown anymore when the historic tag is added. The addr:housenumber tag is still there with the correct value, the number is just not shown anymore on the editor map.

Please provide any additional information below. Attach a screenshot if
possible.
Pick any house which has the heritage tag and play with the heritage tag to see the effect.
​http://www.openstreetmap.org/browse/changeset/17748082

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-08-07 01:35:24
Last Changed Author: Don-vip
Revision: 6115
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-08-07 00:04:24 +0200 (Wed, 07 Aug 2013)
Last Changed Rev: 6115

Identification: JOSM/1.5 (6115 en_GB) Windows 7 64-Bit
Memory Usage: 494 MB / 494 MB (155 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Xms16m, -Xmx512m]
Dataset consistency test: No problems found

Plugin: buildings_tools (29778)
Plugin: download_along (29778)
Plugin: notes (0.3)
Plugin: print (29529)
Plugin: terracer (29771)
Plugin: utilsplugin2 (29771)

[AlfonZ]

Trying with ​http://www.openstreetmap.org/browse/way/228422283 I can see the housenumber.

Are you by any chance referring to the Potlatch2 style, that indeed doesn't show the housenumber with historic tag?

[anonymous]

Replying to AlfonZ:
Sorry, I thought that I had sent a response. Yes, I'm using the Potlatch 2 style. In fact I use most of the time JOSM style and Potlatch 2 style combined. Bad habit...
Regards,
Gilbert

[AlfonZ]

Patch 9062-name2auto.patch​ changes the text property from name to auto for all ways.
As name is by default the second tag in mappaint.nameOrder, the currently rendered names are not likely to be affected.
I am not sure though, how much customization to the Potlatch2 style is desired in JOSM.

In the meantime you can add custom style area[historic]:closed { text: auto; }, which displays the housenumber just for the historic tag.
EDT: You can also try reordering the JOSM Internal Style and Potlatch2 style. While this displays the housenumber, it changes the visual style as well.

[Don-vip]

In 6366/josm:

fix #9062 - fix rendering of named ways with P2 map style (patch by AlfonZ)

[stoecker]

Milestone renamed