Modify

Opened 6 years ago

Closed 6 years ago

#8973 closed enhancement (fixed)

[Patch] Preset for Traffic light shows a dialog for Pedestrian crossing

Reported by: aceman Owned by: team
Priority: trivial Milestone:
Component: Internal preset Version: tested
Keywords: Cc:

Description

When using Presets->Highways->Waypoints->Traffic signal, the sub-dialog appearing for further details contains attributes for a Pedestrian crossing, e.g. crossing type, crossing type name, cross on horseback, etc.

However, code-wise it is not the same dialog as received from Presets->Highways->Waypoints->Pedestrian crossing. There the labels are bit differently worded, but the meaning is the same.

Attachments (3)

josm_8973.diff (1.9 KB) - added by skyper 6 years ago.
patch
josm_8973_v2.diff (4.0 KB) - added by skyper 6 years ago.
patch version 2
josm_8973_v3.diff (4.1 KB) - added by skyper 6 years ago.
unmodified version 3

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by skyper

Attachment: josm_8973.diff added

patch

comment:1 Changed 6 years ago by skyper

Priority: normaltrivial
Summary: Preset for Traffic light shows a dialog for Pedestrian crossing[Patch ]Preset for Traffic light shows a dialog for Pedestrian crossing
Type: defectenhancement

Find attached patch solving this trivial problem.

Last edited 6 years ago by skyper (previous) (diff)

comment:2 Changed 6 years ago by aceman

I can't run with the patch but from just reading it it does not seem to solve the problem.
The updating of texts in <key key="highway" value="crossing" /> seem fine, just fix the introcuded typo in "Pedestrian crossing typ" (should be type). Please add <space /> after the <label> as other dialogs have.

But the traffic signals dialog is unfixed.
Under <key key="highway" value="traffic_signals" /> you need to remove all the current optional elements and add those relevant to a traffic signals, from http://wiki.openstreetmap.org/wiki/Traffic_signals. Also please add a <label> and <space>.

comment:3 in reply to:  2 Changed 6 years ago by skyper

Replying to aceman:

Now, I better understand your problem. Find version 2 attached.

The updating of texts in <key key="highway" value="crossing" /> seem fine, just fix the introcuded typo in "Pedestrian crossing typ" (should be type). Please add <space /> after the <label> as other dialogs have.

fixed.

But the traffic signals dialog is unfixed.
Under <key key="highway" value="traffic_signals" /> you need to remove all the current optional elements and add those relevant to a traffic signals, from http://wiki.openstreetmap.org/wiki/Traffic_signals.

Well, taginfo shows different usage (traffic_signal and crossing).

I my opinion, objects which are related to a way inline like traffic_signals, traffic_signs, enforcements and turn_restrictions can not be mapped as a node as they are often direction dependent.

Also please add a <label> and <space>.

I did try to make it more precise with labels.

Changed 6 years ago by skyper

Attachment: josm_8973_v2.diff added

patch version 2

comment:4 Changed 6 years ago by aceman

I have never seen highway=traffic_signals together with crossing=traffic_signals but OK, if the stats say so and people use it...

Then the current patch can be landed, thanks.

comment:5 Changed 6 years ago by Don-vip

Summary: [Patch ]Preset for Traffic light shows a dialog for Pedestrian crossing[Patch] Preset for Traffic light shows a dialog for Pedestrian crossing

comment:6 Changed 6 years ago by aceman

Will you please check the patch in?

comment:7 Changed 6 years ago by Don-vip

I have trouble to apply it, is it possible to attach a new one against latest revision ? Thanks

Changed 6 years ago by skyper

Attachment: josm_8973_v3.diff added

unmodified version 3

comment:8 in reply to:  7 Changed 6 years ago by skyper

Replying to Don-vip:

I have trouble to apply it, is it possible to attach a new one against latest revision ? Thanks

Strange, a simple patch did work.

Find updated josm_8973_v3.diff patch attached.

comment:9 Changed 6 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6190/josm:

fix #8973 - presets: allow text attribute on optional item to set custom text + fix traffic_light/pedestrian corssing (modified patch by skyper)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.