Modify

Opened 12 years ago

Closed 12 years ago

#8969 closed enhancement (fixed)

[Patch] Make a non-persistent yes or no option when adding existing members to a relation

Reported by: maarten Owned by: team
Priority: normal Milestone: 14.01
Component: Core Version: tested
Keywords: Cc:

Description

Currently, when you add a member to a relation and the member is already in the relation, there is only a global option to mark if you want a message asking you if you want this (message.add_primitive_to_relation). You can set this message to false when you add the member, but then it is persistent.
If you add multiple already existing members to the relation, you have to press yes or no for each member you want to add.
It would be nice to have a non-persistent "yes to all" or "no to all" option in that dialog.

Attachments (1)

non-persistent-checkbox.patch (7.6 KB ) - added by windu.2b 12 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by windu.2b, 12 years ago

I made a patch, which adds a checkbox "do not show again (just this time)". If checked, all primitives are added (or not, depending if you click on the yes or no button), but this option is not recorded : next time, the same question will be asked again.

by windu.2b, 12 years ago

comment:2 by skyper, 12 years ago

This option would be useful in almost all dialogs when more than one object is selected (revert, delete ...) or more than one membership is delete (property toggle dialog).

comment:3 by simon04, 12 years ago

Summary: Make a non-persistent yes or no option when adding existing members to a relation[Patch] Make a non-persistent yes or no option when adding existing members to a relation

comment:4 by simon04, 12 years ago

Resolution: fixed
Status: newclosed

In 6594/josm:

fix #8969 fix #9394 - add "Do not show again (this session)" choice, and in addition "Do not show again (this operation)" if a bulk operation has been marked in the code

The dialog displays 3 or 4 radio boxes with the labels:

  • "Show this dialog again the next time"
  • "Do not show again (this operation)"
  • "Do not show again (this session)"
  • "Do not show again (remembers choice)"

comment:5 by simon04, 12 years ago

Resolution: fixed
Status: closedreopened

windu.2b, thank you for the patch. Instead of using separate preference entries, I decided to use a HashMap to not have the _nonPersistent persisted.

skyper, good point. Feel free to identify more such operations, this cannot easily within the code.

comment:6 by simon04, 12 years ago

In 6595/josm:

see #8969 - add "Do not show again (this operation)" for "Really delete selection from relation"

comment:7 by simon04, 12 years ago

Milestone: 14.01

in reply to:  5 comment:8 by simon04, 12 years ago

Resolution: fixed
Status: reopenedclosed

Replying to skyper:

This option would be useful in almost all dialogs when more than one object is selected (revert, delete ...) or more than one membership is delete (property toggle dialog).

Replying to simon04:

skyper, good point. Feel free to identify more such operations, this cannot easily within the code.

For additional actions, please open a new ticket. :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.